New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 594858 link

Starred by 1 user
Status: Fixed
Owner:
█ imch...@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Return list of origins with sink list updates

Project Member Reported by imch...@chromium.org, Mar 15 2016 
Plan will be as follows:
- Associate an origin with a MediaSinksObserver.
- Modify sink list updates to include a list of origins for which the sink list is valid. The list of origins will be used to determine whether a given MediaSinksObserver has access to the updated list. We will use an empty origin list to denote that the result is valid for all origins.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872

commit c9adbb1e8d955e1f658d92578ab5a51e4dbc8872
Author: imcheng <imcheng@chromium.org>
Date: Tue Mar 15 22:17:04 2016

[Media Router] Add origins to sink query results.

Takes over https://codereview.chromium.org/1693963003/

Add |origins| to |OnSinksReceived| API from MRPM to MR.
If |origins| is non-empty, then the result of sink query
is only valid for those origins. Otherwise, the result is
valid for all origins, which is the legacy behavior. The
origin checking is done in base MediaSinksObserver class,
which will call into the version of |OnSinksReceived|
overridable by children classes.

BUG= 594858 

Review URL: https://codereview.chromium.org/1784533004

Cr-Commit-Position: refs/heads/master@{#381332}

[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/media/router/media_router.mojom
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/media/router/media_router_mojo_impl.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/media/router/media_router_mojo_impl.h
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/media/router/media_sinks_observer.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/media/router/media_sinks_observer.h
[add] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/media/router/media_sinks_observer_unittest.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/media/router/presentation_media_sinks_observer.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/media/router/presentation_media_sinks_observer.h
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/ui/ash/cast_config_delegate_media_router.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/ui/webui/media_router/query_result_manager.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/ui/webui/media_router/query_result_manager.h
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/test/media_router/test_media_sinks_observer.cc
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/chrome/test/media_router/test_media_sinks_observer.h
[modify] https://crrev.com/c9adbb1e8d955e1f658d92578ab5a51e4dbc8872/extensions/renderer/resources/media_router_bindings.js

Comment 2 by imch...@chromium.org, Mar 16 2016

Labels: Merge-Request-50

Comment 3 by tin...@google.com, Mar 16 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 16 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80b7d507c5a3f96feaa0b09276ef80692ab421fe

commit 80b7d507c5a3f96feaa0b09276ef80692ab421fe
Author: Derek Cheng <imcheng@chromium.org>
Date: Wed Mar 16 22:49:44 2016

[Media Router] Add origins to sink query results.

Takes over https://codereview.chromium.org/1693963003/

Add |origins| to |OnSinksReceived| API from MRPM to MR.
If |origins| is non-empty, then the result of sink query
is only valid for those origins. Otherwise, the result is
valid for all origins, which is the legacy behavior. The
origin checking is done in base MediaSinksObserver class,
which will call into the version of |OnSinksReceived|
overridable by children classes.

BUG= 594858 

Review URL: https://codereview.chromium.org/1784533004

Cr-Commit-Position: refs/heads/master@{#381332}
(cherry picked from commit c9adbb1e8d955e1f658d92578ab5a51e4dbc8872)

Review URL: https://codereview.chromium.org/1806153002 .

Cr-Commit-Position: refs/branch-heads/2661@{#263}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/media/router/media_router.mojom
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/media/router/media_router_mojo_impl.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/media/router/media_router_mojo_impl.h
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/media/router/media_sinks_observer.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/media/router/media_sinks_observer.h
[add] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/media/router/media_sinks_observer_unittest.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/media/router/presentation_media_sinks_observer.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/media/router/presentation_media_sinks_observer.h
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/ui/ash/cast_config_delegate_media_router.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/ui/webui/media_router/query_result_manager.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/ui/webui/media_router/query_result_manager.h
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/test/media_router/test_media_sinks_observer.cc
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/chrome/test/media_router/test_media_sinks_observer.h
[modify] https://crrev.com/80b7d507c5a3f96feaa0b09276ef80692ab421fe/extensions/renderer/resources/media_router_bindings.js

Comment 5 by imch...@chromium.org, Mar 17 2016

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/992d9e476c70ff9b2113090919c62ee02afb0a4c

commit 992d9e476c70ff9b2113090919c62ee02afb0a4c
Author: Derek Cheng <imcheng@chromium.org>
Date: Wed Mar 30 06:58:43 2016

[Media Router] Cherrypick "add sinks to origin list" to beta

Attempt 2. Previous attempt was rolled back due to test failures.
Original CL: https://codereview.chromium.org/1784533004
Attempt 1: https://codereview.chromium.org/1806153002/

BUG= 594858 

Review URL: https://codereview.chromium.org/1838903006 .

Cr-Commit-Position: refs/branch-heads/2661@{#428}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/media_router.mojom
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/media_router_mojo_impl.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/media_router_mojo_impl.h
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/media_sinks_observer.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/media_sinks_observer.h
[add] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/media_sinks_observer_unittest.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/presentation_media_sinks_observer.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/presentation_media_sinks_observer.h
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/ui/ash/cast_config_delegate_media_router.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/ui/webui/media_router/query_result_manager.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/ui/webui/media_router/query_result_manager.h
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/test/media_router/test_media_sinks_observer.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/test/media_router/test_media_sinks_observer.h
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/extensions/renderer/resources/media_router_bindings.js
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/992d9e476c70ff9b2113090919c62ee02afb0a4c

commit 992d9e476c70ff9b2113090919c62ee02afb0a4c
Author: Derek Cheng <imcheng@chromium.org>
Date: Wed Mar 30 06:58:43 2016

[Media Router] Cherrypick "add sinks to origin list" to beta

Attempt 2. Previous attempt was rolled back due to test failures.
Original CL: https://codereview.chromium.org/1784533004
Attempt 1: https://codereview.chromium.org/1806153002/

BUG= 594858 

Review URL: https://codereview.chromium.org/1838903006 .

Cr-Commit-Position: refs/branch-heads/2661@{#428}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/media_router.mojom
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/media_router_mojo_impl.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/media_router_mojo_impl.h
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/media_sinks_observer.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/media_sinks_observer.h
[add] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/media_sinks_observer_unittest.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/presentation_media_sinks_observer.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/presentation_media_sinks_observer.h
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/ui/ash/cast_config_delegate_media_router.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/ui/webui/media_router/query_result_manager.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/ui/webui/media_router/query_result_manager.h
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/test/media_router/test_media_sinks_observer.cc
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/chrome/test/media_router/test_media_sinks_observer.h
[modify] https://crrev.com/992d9e476c70ff9b2113090919c62ee02afb0a4c/extensions/renderer/resources/media_router_bindings.js
►

Sign in to add a comment