Issue metadata
Sign in to add a comment
|
Security panel: Use the origin itself as the title for the origin view. |
||||||||||||||||||||||||
Issue descriptionA long time ago, Paul came to my desk and we drafted a change to show the origin instead of showing the origin below a large line saying "Origin". I've just uploaded this as [1]. However, this has a few issues: 1. The origin security state icon (which we placed to the left of the origin) makes the text look misaligned. 2. The code assumes that all origins are parseable and renderable as [scheme]://[host][optional port]. The code doesn't have the actual security origin of the resource from the browser, so the parsing is a guess (that can break). 3. We wanted to de-emphasize the :// part of the origin, since it doesn't affect security, but this looks weird. 4. Issue 543900 (how to display the scheme semantically) isn't really settled. I'd like to show "https" in green", Paul and Max want a separated scheme in gray. Since WebInspector.SecurityPanel._processRequest [2] already makes assumptions about origin parseability, I'm okay with ignoring #2. #3 and #4 are also bikeshedding. But I'd like to fix #1 and then finally land [1]. mmccoy@, up for this? [1] https://crrev.com/1803793005 [2] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js&q=_processRequest&l=147
,
Mar 15 2016
,
Mar 15 2016
lgtm on this tweak. fine with ignoring 3&4 :)
,
May 3 2016
https://codereview.chromium.org/1944853002 Screenshot: https://screenshot.googleplex.com/kR34Azo9CFn -mm
,
May 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8a506c092f85ee69272136f0b4e3af915a09f39 commit d8a506c092f85ee69272136f0b4e3af915a09f39 Author: mmccoy <mmccoy@chromium.org> Date: Thu May 05 19:03:21 2016 [DevTools] Security Panel: Use actual origin as textContent for title element. BUG= 594856 Review-Url: https://codereview.chromium.org/1944853002 Cr-Commit-Position: refs/heads/master@{#391864} [modify] https://crrev.com/d8a506c092f85ee69272136f0b4e3af915a09f39/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js [modify] https://crrev.com/d8a506c092f85ee69272136f0b4e3af915a09f39/third_party/WebKit/Source/devtools/front_end/security/originView.css
,
May 10 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Mar 15 2016