Issue metadata
Sign in to add a comment
|
Redline the Security panel |
||||||||||||||||||||||||||
Issue descriptionThe security panel contains various ad-hoc margin and padding decisions. Examples that currently jump out at me: - Sidebar: Horizontal padding alignment - The origin view header (see screenshot - Vertical alignment of text and bullets (text in the sidebar seems a pixel or two too low to me). Ideally Max could give us redlines for the the whole panel, but we already have mocks for the overview [1] and origin views [2]. mmccoy@, could you work with Max to figure out what important tweaks we need? [1] https://folio.googleplex.com/chrome-devtools/028-security-panel/03#%2F01%20-%20B%20-%20Secure%20with%20errors,%20mixed%20content%20(HTTPS_WARNING).png%3Fz=half [2] https://folio.googleplex.com/chrome-devtools/028-security-panel/02#%3Fz=half
,
Mar 15 2016
+max Max, are there any other gaping alignment/redline issues that you see currently in the Security Panel? The vertical alignment of the left-panel items is actually correct (midline), but I'm not sure about the general line-height or box metrics (margin/padding). Thanks!
,
Mar 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8ae1683536cd6b816df9936d0ba0e04b6a6027f commit a8ae1683536cd6b816df9936d0ba0e04b6a6027f Author: mmccoy <mmccoy@chromium.org> Date: Wed Mar 16 23:13:45 2016 [DevTools] Security Panel: Alignment fix for origin views BUG= 594850 Review URL: https://codereview.chromium.org/1801333002 Cr-Commit-Position: refs/heads/master@{#381576} [modify] https://crrev.com/a8ae1683536cd6b816df9936d0ba0e04b6a6027f/third_party/WebKit/Source/devtools/front_end/security/originView.css
,
Aug 13 2016
Max's mocks Issue for 617311 were thorough enough that I ended up redlining all three surfaces of the Security panel there. |
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
.png%3Fz=half){kind=link}
Comment 1 by mmccoy@chromium.org
, Mar 15 2016