Ensure auto-rebaseline builder git commit name/email config is stable across potential builder reprovisioning. |
||||
Issue descriptionCleanup from http://crbug.com/589140 and see also http://crbug.com/593910 - if builder is reprovisioned from scratch today we'd need to manually run git config for user.{name,email} to have things operational again. This is undesirable. - we should either add git config to the bot setup steps, or set env vars or add'l committer params as works in the rebaseline script - if we determine we don't need the --commit-author param in the rebaseline script since we can rely on git config for user.{name,email} in the repo, we should remove it.
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/f56b4dfc380e2821c836774a982e7bf56c3df63e commit f56b4dfc380e2821c836774a982e7bf56c3df63e Author: wkorman@chromium.org <wkorman@chromium.org> Date: Tue Mar 15 19:02:05 2016 Set rebaseline bot name/email in chromium repo via git config. Remove --commit-author from the bot config as it's insufficient for the full rebaseline bot flow. Will remove support for the flag from script itself once we confirm it's not going to be used. BUG= 594817 Review URL: https://codereview.chromium.org/1801213002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299297 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/f56b4dfc380e2821c836774a982e7bf56c3df63e/scripts/slave/recipes/infra/rebaseline_o_matic.expected/rebaseline_o_matic.json [modify] https://crrev.com/f56b4dfc380e2821c836774a982e7bf56c3df63e/scripts/slave/recipes/infra/rebaseline_o_matic.py
,
Mar 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/74f581eed0983b1cd7872d82cd93b336df1a3893 commit 74f581eed0983b1cd7872d82cd93b336df1a3893 Author: wkorman@chromium.org <wkorman@chromium.org> Date: Thu Mar 17 04:13:09 2016 Improve docs on rebaseline git config user name/email override. BUG= 594817 Review URL: https://codereview.chromium.org/1810653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299339 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/74f581eed0983b1cd7872d82cd93b336df1a3893/scripts/slave/recipes/infra/rebaseline_o_matic.py
,
Mar 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/549cbbcd3e66201f260b1e1050645b14601c4189 commit 549cbbcd3e66201f260b1e1050645b14601c4189 Author: wkorman <wkorman@chromium.org> Date: Thu Mar 17 19:47:59 2016 Remove optional --commit-author argument from auto-rebaseline script. The bot now uses 'git config' to explicitly set the intended author/committer user name and email before running the script, rather than routing through the rebaseline script itself. BUG= 594817 , 589140 Review URL: https://codereview.chromium.org/1809723002 Cr-Commit-Position: refs/heads/master@{#381776} [modify] https://crrev.com/549cbbcd3e66201f260b1e1050645b14601c4189/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py [modify] https://crrev.com/549cbbcd3e66201f260b1e1050645b14601c4189/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py [modify] https://crrev.com/549cbbcd3e66201f260b1e1050645b14601c4189/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_mock.py [modify] https://crrev.com/549cbbcd3e66201f260b1e1050645b14601c4189/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py [modify] https://crrev.com/549cbbcd3e66201f260b1e1050645b14601c4189/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
,
Mar 17 2016
,
Mar 18 2016
Fixing component name after Monorail migration
,
Apr 18 2016
Blink>ToolsTest renamed to Blink>Infra
,
Jun 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/a080aa80ed09af9826c6d2331ea250df3af8d819 commit a080aa80ed09af9826c6d2331ea250df3af8d819 Author: wkorman@chromium.org <wkorman@chromium.org> Date: Tue Mar 15 19:02:05 2016 Set rebaseline bot name/email in chromium repo via git config. Remove --commit-author from the bot config as it's insufficient for the full rebaseline bot flow. Will remove support for the flag from script itself once we confirm it's not going to be used. BUG= 594817 Review URL: https://codereview.chromium.org/1801213002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299297 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/a080aa80ed09af9826c6d2331ea250df3af8d819/recipes/recipes/rebaseline_o_matic.expected/rebaseline_o_matic.json [modify] https://crrev.com/a080aa80ed09af9826c6d2331ea250df3af8d819/recipes/recipes/rebaseline_o_matic.py
,
Jun 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/19a82ff8e45c85d310924ac6b0edabb7199a5731 commit 19a82ff8e45c85d310924ac6b0edabb7199a5731 Author: wkorman@chromium.org <wkorman@chromium.org> Date: Thu Mar 17 04:13:09 2016 Improve docs on rebaseline git config user name/email override. BUG= 594817 Review URL: https://codereview.chromium.org/1810653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299339 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/19a82ff8e45c85d310924ac6b0edabb7199a5731/recipes/recipes/rebaseline_o_matic.py |
||||
►
Sign in to add a comment |
||||
Comment 1 by wkorman@chromium.org
, Mar 14 2016