New issue
Advanced search Search tips

Issue 594789 link

Starred by 1 user
Status: Fixed
Owner:
btolsch@chromium.org
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router WebUI] Tabbing through all elements and back to search doesn't enter filter view.

Project Member Reported by btolsch@chromium.org, Mar 14 2016 
The following steps reproduce this problem:
(1) Open MR WebUI.
(2) Use keyboard to tab to search input.
(3) Press escape to leave filter view.
(4) Use tab to cycle back through the UI, back to the search input.
(5) Notice that the UI does not switch to filter view this time.

This is related to the special handling of window/input focus/blur events.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa85d103c33578539738cb88f163f33deb344266

commit aa85d103c33578539738cb88f163f33deb344266
Author: btolsch <btolsch@chromium.org>
Date: Tue Mar 15 19:00:48 2016

[Media Router UI] Fix search results overflow scroll and input focus.

This change fixes the following issues:
 - The full search result list is not accessible when scrolling is necessary.
 - The input focus logic is broken by keyboard tabbing wrapping around the
   document.

BUG= 594789 
R=apacible@chromium.org

Review URL: https://codereview.chromium.org/1801983003

Cr-Commit-Position: refs/heads/master@{#381272}

[modify] https://crrev.com/aa85d103c33578539738cb88f163f33deb344266/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Comment 2 by btolsch@chromium.org, Mar 15 2016

Status: Fixed (was: Started)

Comment 3 by btolsch@chromium.org, Mar 16 2016

Labels: Merge-Request-50

Comment 4 by tin...@google.com, Mar 16 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)

Comment 5 by gov...@chromium.org, Mar 16 2016 

Please merge your change to M50 branch 2661 some time this week if it is a safe merge. Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 18 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/396e0096271a978eba71babad16b0a6ce57dde4f

commit 396e0096271a978eba71babad16b0a6ce57dde4f
Author: btolsch <btolsch@chromium.org>
Date: Fri Mar 18 20:11:01 2016

[Media Router UI] Fix search results overflow scroll and input focus.

This change fixes the following issues:
 - The full search result list is not accessible when scrolling is necessary.
 - The input focus logic is broken by keyboard tabbing wrapping around the
   document.

This change was dependent on this CL, which was also after M50 branched: https://codereview.chromium.org/1772813002/
This change includes everything from both that is necessary.

BUG= 594789 
R=apacible@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1801983003

Cr-Commit-Position: refs/heads/master@{#381272}
(cherry picked from commit aa85d103c33578539738cb88f163f33deb344266)

Review URL: https://codereview.chromium.org/1810223002

Cr-Commit-Position: refs/branch-heads/2661@{#284}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/396e0096271a978eba71babad16b0a6ce57dde4f/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
►

Sign in to add a comment