Chromium should verify the compiler version used to build it |
||
Issue description
Chromium builds with VS 2015, but not with VS 2015 RTM. Building with the wrong version may fail in subtle and non-obvious ways (bad code-gen, etc.) so allowing this is just creating pitfalls for developers. Similarly, Chromium (currently) builds with VS 2013 but requires at least Update 4 in order to do this.
There should be a file in base that checks the compiler version. Something like:
#if _MSC_VER == 1800
#if _MSC_FULL_VER < 1800xyz
#error VS 2013 builds require VS 2013 Update 4 or higher
#endif
#elif _MSC_VER == 1900
#if _MSC_FULL_VER < 1900xyz
#error VS 2015 builds require VS 2015 Update 1 or higher
#endif
#elif defined(_MSC_VER)
#error Unknown VC++ version
#endif
,
Jul 13 2016
Apparently I failed to tag my CL that added a check for Update 2 of VS 2015 with this bug number. Here is the CL - this bug is now fixed. commit c833e65d0234f6f8950b46f5c54e083d024a26bd Author: brucedawson <brucedawson@chromium.org> Date: Thu Apr 28 14:46:30 2016 -0700 Verify that Update 2 of VS 2015 is used to build Chromium It is easy to accidentally build Chromium with an earlier version of Visual Studio, but earlier versions have bugs and differences that can lead to problems and cause confusion. BUG= 440500 Review-Url: https://codereview.chromium.org/1849423002 Cr-Commit-Position: refs/heads/master@{#390494} |
||
►
Sign in to add a comment |
||
Comment 1 by cbiesin...@chromium.org
, Jul 13 2016