New issue
Advanced search Search tips

Issue 594750 link

Starred by 1 user
Status: Verified
Owner:
avkodipelli@chromium.org
Closed: Jul 2016
Cc:
rohi...@chromium.org
vsu...@chromium.org
posciak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Dynamically add 'controls' attribute to video.html file

Project Member Reported by mu...@chromium.org, Mar 14 2016 
Having controls set by default in the video.html file is breaking image comparison tests.

This is because all video tests are sharing this html file. 

We should support dynamically adding these control as needed by test.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d81b422519f47ce35ed8c84c1e33334a9f38c90e

commit d81b422519f47ce35ed8c84c1e33334a9f38c90e
Author: avinash kodipelli <avkodipelli@chromium.org>
Date: Tue Jul 26 17:27:14 2016

Adding video controls attribute to html file

This will give flexibility to add video controls dynamically

BUG= chromium:594750 
TEST=manual

Change-Id: Ide8eeafd8deee5103cbec8cfa15c0a6e89538da5
Reviewed-on: https://chromium-review.googlesource.com/363470
Commit-Ready: Avinash Kodipelli <avkodipelli@chromium.org>
Tested-by: Avinash Kodipelli <avkodipelli@chromium.org>
Reviewed-by: Rohit Makasana <rohitbm@chromium.org>

[modify] https://crrev.com/d81b422519f47ce35ed8c84c1e33334a9f38c90e/client/cros/video/video.html
[modify] https://crrev.com/d81b422519f47ce35ed8c84c1e33334a9f38c90e/client/cros/video/native_html5_player.py

Comment 2 by avkodipelli@chromium.org, Jul 29 2016

Cc: vsu...@chromium.org
Status: Fixed (was: Untriaged)

Comment 3 by patricia@chromium.org, Aug 29 2016

Labels: VerifyIn-54

Comment 4 by avkodipelli@chromium.org, Aug 29 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment