New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594730 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 594728



Sign in to add a comment

Filesystem apptests -> shelltests

Project Member Reported by ben@chromium.org, Mar 14 2016

Issue description

https://chromium.googlesource.com/chromium/src/+/master/components/filesystem/files_test_base.h & further derived classes

Should be converted to be a ShellTest.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/716b6174dbd421bbec303657fdbf29069fe46ada

commit 716b6174dbd421bbec303657fdbf29069fe46ada
Author: erg <erg@chromium.org>
Date: Fri Mar 18 18:30:29 2016

Convert filesystem_apptests to shelltests.

BUG= 594730 

Review URL: https://codereview.chromium.org/1814983002

Cr-Commit-Position: refs/heads/master@{#382021}

[modify] https://crrev.com/716b6174dbd421bbec303657fdbf29069fe46ada/BUILD.gn
[modify] https://crrev.com/716b6174dbd421bbec303657fdbf29069fe46ada/components/filesystem/BUILD.gn
[delete] https://crrev.com/d029a988f4c493a6df894c68d7fcd41ae160af31/components/filesystem/apptest_manifest.json
[modify] https://crrev.com/716b6174dbd421bbec303657fdbf29069fe46ada/components/filesystem/files_test_base.cc
[modify] https://crrev.com/716b6174dbd421bbec303657fdbf29069fe46ada/components/filesystem/files_test_base.h
[add] https://crrev.com/716b6174dbd421bbec303657fdbf29069fe46ada/components/filesystem/test_manifest.json
[modify] https://crrev.com/716b6174dbd421bbec303657fdbf29069fe46ada/mojo/shell/public/cpp/lib/shell_test.cc
[modify] https://crrev.com/716b6174dbd421bbec303657fdbf29069fe46ada/mojo/shell/public/cpp/shell_test.h
[modify] https://crrev.com/716b6174dbd421bbec303657fdbf29069fe46ada/mojo/tools/data/apptests
[modify] https://crrev.com/716b6174dbd421bbec303657fdbf29069fe46ada/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/716b6174dbd421bbec303657fdbf29069fe46ada/testing/buildbot/gn_isolate_map.pyl

Comment 2 by e...@chromium.org, Mar 18 2016

Status: Fixed (was: Assigned)

Sign in to add a comment