New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594722 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Tab sharing for inactive tab broken

Project Member Reported by niklase@chromium.org, Mar 14 2016

Issue description

Version: 50
OS: Linux

What steps will reproduce the problem?
(1) Start tab sharing a youtube tab that's not the active tab

The tab is frozen until it's picked as an active tab. If the tab becomes inactive after starting sharing it works as it should.

 

Comment 1 by gyzhou@chromium.org, Mar 15 2016

Selected inactive tab will be activated and put to the front of the browser. This mimics the window sharing which brings the selected window to the front of desktop.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bfd41b23017c287cf269f34ca563ad4072a6bf4

commit 4bfd41b23017c287cf269f34ca563ad4072a6bf4
Author: gyzhou <gyzhou@chromium.org>
Date: Wed Mar 16 16:49:41 2016

For Desktop tab sharing, activate selected inactive tab

BUG= 594722 

Review URL: https://codereview.chromium.org/1805583002

Cr-Commit-Position: refs/heads/master@{#381473}

[modify] https://crrev.com/4bfd41b23017c287cf269f34ca563ad4072a6bf4/chrome/browser/ui/views/desktop_media_picker_views.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67d45bc3c87f99d13559ed6623fe4c674642330e

commit 67d45bc3c87f99d13559ed6623fe4c674642330e
Author: gyzhou <gyzhou@chromium.org>
Date: Wed Mar 16 17:56:32 2016

For desktop tab sharing in mac, activate selected tab

This CL mimics the code for desktop platforms other than mac in https://codereview.chromium.org/1805583002/

BUG= 594722 

Review URL: https://codereview.chromium.org/1812543002

Cr-Commit-Position: refs/heads/master@{#381491}

[modify] https://crrev.com/67d45bc3c87f99d13559ed6623fe4c674642330e/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm

Comment 4 by gyzhou@chromium.org, Mar 16 2016

Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Fixed (was: Assigned)
Cc: srnarayanan@chromium.org
Thanks for the fixes, gyzhou@! Are there any aspects of tab sharing that are suitable for unit or other automated tests to prevent this from regressing?

Comment 6 by gyzhou@chromium.org, Mar 17 2016

This bug is more a behavior issue than something broken. Internal rendering may be suspended for inactive tab. therefore, the capture inactive tab may be frozen. Activating the inactive tab changes this behavior. I guess a extra unit test may not be definitely needed.
Verified in M51 51.0.2704.2 in Linux and Windows
Selecting inactive tab activates it and puts it in front
In Windows, though the inactive tab becomes active, on tab capture, it is behind the desktop capture dialog (as in screenshot) 
Untitled.png
181 KB View Download

Comment 9 by srcv@chromium.org, Apr 18 2016

On CrOS :

Observed that selecting inactive tab is bringing that tab to the front of the browser but Desktop capture extension dialog box stays on top of that inactive tab making desktop capture extension dialog box as the top most tab on the browser.

gyzhou@ confirmed that is the expected behavior for CrOS. 

srnarayanan@ : Please update this bug after confirming the expected behavior for windows.

Inactive_tab_sharing_CrOS.jpeg
1.8 MB View Download
Cc: tnakamura@chromium.org
Status: Verified (was: Fixed)
Filing https://bugs.chromium.org/p/chromium/issues/detail?id=605340 for comment #8 above, and closing this as Verified

Sign in to add a comment