Tab sharing for inactive tab broken |
||||
Issue descriptionVersion: 50 OS: Linux What steps will reproduce the problem? (1) Start tab sharing a youtube tab that's not the active tab The tab is frozen until it's picked as an active tab. If the tab becomes inactive after starting sharing it works as it should.
,
Mar 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bfd41b23017c287cf269f34ca563ad4072a6bf4 commit 4bfd41b23017c287cf269f34ca563ad4072a6bf4 Author: gyzhou <gyzhou@chromium.org> Date: Wed Mar 16 16:49:41 2016 For Desktop tab sharing, activate selected inactive tab BUG= 594722 Review URL: https://codereview.chromium.org/1805583002 Cr-Commit-Position: refs/heads/master@{#381473} [modify] https://crrev.com/4bfd41b23017c287cf269f34ca563ad4072a6bf4/chrome/browser/ui/views/desktop_media_picker_views.cc
,
Mar 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67d45bc3c87f99d13559ed6623fe4c674642330e commit 67d45bc3c87f99d13559ed6623fe4c674642330e Author: gyzhou <gyzhou@chromium.org> Date: Wed Mar 16 17:56:32 2016 For desktop tab sharing in mac, activate selected tab This CL mimics the code for desktop platforms other than mac in https://codereview.chromium.org/1805583002/ BUG= 594722 Review URL: https://codereview.chromium.org/1812543002 Cr-Commit-Position: refs/heads/master@{#381491} [modify] https://crrev.com/67d45bc3c87f99d13559ed6623fe4c674642330e/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
,
Mar 16 2016
,
Mar 17 2016
Thanks for the fixes, gyzhou@! Are there any aspects of tab sharing that are suitable for unit or other automated tests to prevent this from regressing?
,
Mar 17 2016
This bug is more a behavior issue than something broken. Internal rendering may be suspended for inactive tab. therefore, the capture inactive tab may be frozen. Activating the inactive tab changes this behavior. I guess a extra unit test may not be definitely needed.
,
Apr 13 2016
Verified in M51 51.0.2704.2 in Linux and Windows Selecting inactive tab activates it and puts it in front
,
Apr 18 2016
In Windows, though the inactive tab becomes active, on tab capture, it is behind the desktop capture dialog (as in screenshot)
,
Apr 18 2016
On CrOS : Observed that selecting inactive tab is bringing that tab to the front of the browser but Desktop capture extension dialog box stays on top of that inactive tab making desktop capture extension dialog box as the top most tab on the browser. gyzhou@ confirmed that is the expected behavior for CrOS. srnarayanan@ : Please update this bug after confirming the expected behavior for windows.
,
Apr 20 2016
Filing https://bugs.chromium.org/p/chromium/issues/detail?id=605340 for comment #8 above, and closing this as Verified |
||||
►
Sign in to add a comment |
||||
Comment 1 by gyzhou@chromium.org
, Mar 15 2016