New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594718 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Changes to components/test_runner and content/shell/renderer/layout_test should trigger webkit_tests

Project Member Reported by lukasza@chromium.org, Mar 14 2016

Issue description

CQ should run layout tests (aka webkit_tests step) on a CL with changes to components/test_runner and content/shell/renderer/layout_test.  This didn't happen in https://codereview.chromium.org/1787743003/#ps20001 (i.e. linux_chromium_rel_ng bot didn't run webkit_tests step and was green despite the fact that webkit_tests started to fail on linux_blink_rel bot).
 
Pawel - it this a dupe of  https://crbug.com/583119 , or would this be a separate issue? (i.e. with a different fix and/or a different root cause)
Owner: phajdan.jr@chromium.org
Status: Assigned (was: Untriaged)
It's different. This one is easier.

Comment 3 by aga...@chromium.org, Apr 26 2016

Components: Infra>CQ
Labels: -Infra-CommitQueue
Status: Started (was: Assigned)
Uploaded https://codereview.chromium.org/1916053005 .
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/88fd52d934fe23978321f4fb5d82c3bf7695fac2

commit 88fd52d934fe23978321f4fb5d82c3bf7695fac2
Author: phajdan.jr@chromium.org <phajdan.jr@chromium.org>
Date: Thu Apr 28 09:03:02 2016

chromium_trybot: add components/test_runner and content/shell/renderer/layout_test to CHROMIUM_BLINK_TESTS_PATHS

BUG= chromium:594718 

Review-Url: https://codereview.chromium.org/1916053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300270 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/88fd52d934fe23978321f4fb5d82c3bf7695fac2/scripts/slave/recipes/chromium_trybot.py

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87152

------------------------------------------------------------------
r87152 | recipe-roller@chromium.org | 2016-04-28T09:23:15.893189Z

-----------------------------------------------------------------
Status: Fixed (was: Started)

Sign in to add a comment