So far, we have at least 8 FakeSafeBrowsingService or TestSafeBrowsingService created in different browser_tests/unit_tests: https://code.google.com/p/chromium/codesearch#search/&q=%22:%20public%20SafeBrowsingService%22&sq=package:chromium&type=cs We should make a test fixture under chrome/browser/safe_browsing that can be reused among these tests to simply test writing.
Issue 438754 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7526f825c981ac645f6287b0b11b24e48a336cae commit 7526f825c981ac645f6287b0b11b24e48a336cae Author: jialiul <jialiul@chromium.org> Date: Fri May 20 22:22:27 2016 Create test fixture for SafeBrowsingService and its factory to simply test writing. Also squeeze in a minor fix in DownloadDangerPrompt classes to prevent download report sent for a already terminated or not dangerous download. BUG= 594683 Review-Url: https://codereview.chromium.org/1943993006 Cr-Commit-Position: refs/heads/master@{#395183} [modify] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/download/download_browsertest.cc [modify] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/download/download_danger_prompt.cc [modify] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/download/download_danger_prompt_browsertest.cc [modify] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/prerender/prerender_browsertest.cc [modify] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc [modify] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc [modify] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/safe_browsing/safe_browsing_service.h [modify] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc [modify] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/safe_browsing/safe_browsing_test.cc [add] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/safe_browsing/test_safe_browsing_service.cc [add] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/safe_browsing/test_safe_browsing_service.h [modify] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/safe_browsing/ui_manager.h [modify] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc [modify] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/browser/ui/views/download/download_danger_prompt_views.cc [modify] https://crrev.com/7526f825c981ac645f6287b0b11b24e48a336cae/chrome/chrome_browser.gypi
Comment 1 by asanka@chromium.org
, Mar 15 2016