New issue
Advanced search Search tips

Issue 594679 link

Starred by 1 user
Status: Assigned
Owner:
vmp...@chromium.org
Cc:
ericrk@chromium.org
enne@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Unify different canvas creation into a single spot in CC

Project Member Reported by vmp...@chromium.org, Mar 14 2016 
In CC, we have several canvas overrides that filter the canvas in various ways. I think all of this process should be unified so that a consistent SkCanvas can be passed to the raster source.

The raster source will then determine how to wrap the given canvas based on some settings struct that should be passed along with the canvas.

Comment 1 by vmp...@chromium.org, Mar 14 2016

Labels: -Type-Bug Type-Feature
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec4a417cf5346d41f6fc64f0396f83ed4b340696

commit ec4a417cf5346d41f6fc64f0396f83ed4b340696
Author: vmpstr <vmpstr@chromium.org>
Date: Mon Mar 14 22:51:06 2016

cc: Refactor SkipImageCanvas and create it during playback.

This patch moves SkipImageCanvas into a separate file in the same
directory as ImageHijackCanvas and also moves the creation of
SkipImageCanvas to raster source playback (the same place as
ImageHijackCanvas is created).

BUG=594679
R=enne, ericrk
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1799883002

Cr-Commit-Position: refs/heads/master@{#381101}

[modify] https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696/cc/BUILD.gn
[modify] https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696/cc/cc.gyp
[modify] https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696/cc/debug/rasterize_and_record_benchmark_impl.cc
[modify] https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696/cc/output/software_renderer.cc
[modify] https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696/cc/playback/display_list_raster_source.cc
[modify] https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696/cc/playback/display_list_raster_source.h
[modify] https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696/cc/playback/display_list_raster_source_unittest.cc
[add] https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696/cc/playback/skip_image_canvas.cc
[add] https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696/cc/playback/skip_image_canvas.h
[modify] https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696/cc/raster/gpu_rasterizer.cc
[modify] https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696/cc/raster/tile_task_worker_pool.cc
[modify] https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696/cc/test/fake_display_list_raster_source.cc
[modify] https://crrev.com/ec4a417cf5346d41f6fc64f0396f83ed4b340696/cc/test/fake_display_list_raster_source.h
►

Sign in to add a comment