MD Toolbar: Hover state with theme is not noticeable |
||||
Issue descriptionVersion: 51.0.2673.0 OS: 10_11_3 What steps will reproduce the problem? (1) Install https://chrome.google.com/webstore/detail/greyscale/olagifopidokilmoeiiejpmpfclmopfk (2) Hover over a toolbar button (3) Can't tell if there's a hover state What is the expected output? What do you see instead? The screen shot shows the reload button being hovered-over, compared to the forward button. Please use labels and text to provide additional information.
,
May 9 2016
I believe this is because the MD code is determining that this theme is a "dark" theme and so is using the 8% white hover states. I need to see why it considers it a dark theme.
,
May 18 2016
It looks like the toolbar was always using the partially-transparent light hover background, which made the background invisible against a light theme.
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94c1aa12416a70721b4bf4b0cb3b416282e5060e commit 94c1aa12416a70721b4bf4b0cb3b416282e5060e Author: shrike <shrike@chromium.org> Date: Thu May 19 16:49:55 2016 [Mac][Material Design] Fix toolbar icon hover bg for custom themes. The toolbar button was set to always show the light version of the hover background. For light themes, this rendered the hover background invisible. R=avi@chromium.org BUG= 594678 Review-Url: https://codereview.chromium.org/1987053005 Cr-Commit-Position: refs/heads/master@{#394797} [modify] https://crrev.com/94c1aa12416a70721b4bf4b0cb3b416282e5060e/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
,
May 19 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by shrike@chromium.org
, Mar 22 2016Cc: shrike@chromium.org
Labels: M-51
Owner: sgabr...@chromium.org