Issue 594673 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ chongz@chromium.org Last visit > 30 days ago
Closed:	Mar 2016
Cc:	█ chongz@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Bug
Hotlist-Input-Dev M-51

Blocking:
issue 227231

Dead key should produce DomKey "Dead"

Project Member Reported by chongz@chromium.org, Mar 14 2016

Issue description

Version: Chrome Dev 50.0.2645.0
OS: Android 6.0.1

What steps will reproduce the problem?
(1) Make sure "experimental Web Platform features" is enabled in chrome://flags
(2) Navigate to http://nonan.jp/keyevent/input.html
(3) Connect to a physical keyboard and switch to French layout
(4) Focus on the field and press '['

What is the expected output? 
Should produce DomKey "Dead".

What do you see instead?
Produce DomKey "MediaLast".

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc24530936e142a35a2f55e2e16726f3475758db

commit cc24530936e142a35a2f55e2e16726f3475758db
Author: chongz <chongz@chromium.org>
Date: Tue Mar 29 15:07:46 2016

[Android] Pass original unicode character to blink for dead keys

Accoding to spec pressing a dead key should produce DomKey "Dead".

Currently we only send a synthetic key event to blink if it's a dead
key, this CL attaches original unicode character of the key event to
the synthetic key event, so blink can get DomKey from it.

SPEC=https://w3c.github.io/uievents/#keys-dead
BUG= 594673 

Review URL: https://codereview.chromium.org/1801033003

Cr-Commit-Position: refs/heads/master@{#383723}

[modify] https://crrev.com/cc24530936e142a35a2f55e2e16726f3475758db/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
[modify] https://crrev.com/cc24530936e142a35a2f55e2e16726f3475758db/content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java
[modify] https://crrev.com/cc24530936e142a35a2f55e2e16726f3475758db/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java
[modify] https://crrev.com/cc24530936e142a35a2f55e2e16726f3475758db/content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionTest.java

Comment 2 by chongz@chromium.org, Mar 29 2016

Labels: M-51
Status: Fixed (was: Started)

►

Issue 594673 link

Issue metadata

Dead key should produce DomKey "Dead"

Issue description

Comment 1 by bugdroid1@chromium.org, Mar 29 2016

Comment 1 Deleted

Comment 2 by chongz@chromium.org, Mar 29 2016

Comment 2 Deleted

Sign in to add a comment