Scroll offsets don't get reset between tests |
|||||
Issue descriptionLooking at these layout tests 1. fast/events/scale-and-scroll-body.html 2. fast/events/scale-and-scroll-iframe-body.html Running the first test before the second test makes the second test failing. Particularly the output image of the second test does show the extra offset (i..e (100, 100) that was used in the first test). If you change that (100, 100) scroll offset in the first test that value will be shown exactly in the second test.
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/228ea6faf71a8e33938caf6d2c04f80ae786dbf2 commit 228ea6faf71a8e33938caf6d2c04f80ae786dbf2 Author: nzolghadr <nzolghadr@chromium.org> Date: Tue Mar 15 12:14:56 2016 Remove fixed tests from TestExpectation file These tests were failing because of a state that was not reset in the content_shell and it was being carried over from other tests and resulting these test to fail. The blocking bug is now fixed and that state is being reset so these tests are always passing now. Marking the rest of the tests for another bug as they seem to have another reason for failing. BUG= 591821 , 594672 Review URL: https://codereview.chromium.org/1798963003 Cr-Commit-Position: refs/heads/master@{#381211} [modify] https://crrev.com/228ea6faf71a8e33938caf6d2c04f80ae786dbf2/third_party/WebKit/LayoutTests/TestExpectations
,
Jul 14 2016
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8c31351d42c9ed62418ac6fcab6acea74b094db commit c8c31351d42c9ed62418ac6fcab6acea74b094db Author: qyearsley <qyearsley@chromium.org> Date: Thu Sep 29 22:23:14 2016 Run update-test-expectations after making it less conservative. The change http://crrev.com/2380173002 would make update-test-expectations delete lines as long as the test appears non-flaky on all configurations with existing builders, ignoring configurations with no existing builders. This CL is the result of running that script -- so for any lines deleted here, that script has found that in recent runs for all existing matching continuous builders, the test appears non-flaky, i.e. passing all recent runs. BUG=248938, 339597 , 352405 , 364250 , 381730 , 404597 , 410949 , 419696 , 473718 , 498539 , 518915 , 520169 , 520180 , 520183 ,520187, 520191 , 520612 , 520614 , 521084 ,521086, 521090 , 521093 , 521094 , 521099 , 521107 , 521855 , 522645 , 542541 , 552532 , 587593 , 587779 ,588103, 594595 , 594672 , 597572 , 613510 , 614197 , 622672 , 629711 Review-Url: https://codereview.chromium.org/2384573002 Cr-Commit-Position: refs/heads/master@{#421954} [modify] https://crrev.com/c8c31351d42c9ed62418ac6fcab6acea74b094db/third_party/WebKit/LayoutTests/TestExpectations
,
Mar 22 2017
Note, the that change (in #4) removed some expectations for tests which didn't seem to be failing flakily, and now the set tests marked in TestExpectations is: crbug.com/594672 fast/events/iframe-object-onload.html [ Failure Pass ] crbug.com/594672 fast/events/scale-and-scroll-iframe-body.html [ Failure Pass ] crbug.com/594672 fast/events/updateLayoutForHitTest.html [ Failure Pass ] Trying to reproduce this failure: ./run-webkit-tests --order=none fast/events/scale-and-scroll-body.html fast/events/scale-and-scroll-iframe-body.html ./run-webkit-tests --order=none fast/events/scale-and-scroll-iframe-body.html fast/events/scale-and-scroll-body.html In both cases, fast/events/scale-and-scroll-iframe-body.html and the image diff was the difference between present or missing scrollbars. I guess I'm reproducing this wrong? nzolghadr@, how did you reproduce this originally?
,
Dec 18 2017
nzolghadr@, any comment on #5?
,
Feb 21 2018
Ping nzolghadr@
,
Feb 21 2018
Sorry for the delay and thanks for the ping. I missed the notification for this issue. Quinten, I don't seem to be able to reproduce this either on ToT. Maybe it got resolved in some other way since then.
,
Apr 23 2018
The tests from #5 have consistent failures on the bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=fast%2Fevents%2FupdateLayoutForHitTest.html%2C%20fast%2Fevents%2Fiframe-object-onload.html%2C%20fast%2Fevents%2Fscale-and-scroll-iframe-body.html nzolghadr@, can the failures just be rebaselined now that they no longer seem to be flaky?
,
Apr 23 2018
Sure.
,
Jun 25 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8f2c12152620b145329a0125b7510feb86858b5 commit e8f2c12152620b145329a0125b7510feb86858b5 Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Wed Jun 27 14:29:58 2018 Rebaseline some fast/events tests that were formerly flaky Back in early 2016, some tests were marked flaky and whatever was causing the flakiness has since been fixed -- they are currently failing because the existing expectations no longer match the results that are produced. Rebaseline the tests and remove them from TestExpectations as per the discussion in the bug, while also adjusting some of the tests in the process: * fast/events/scale-and-scroll-iframe-body.html: Explicitly disable scrollbars in the iframe after http://crrev.com/398951, otherwise we end up with platform-specific PNG expectations due to the differences in the scrollbars. * fast/events/updateLayoutForHitTest.html: Avoid confusion by removing some style assignments that had been causing console errors ever since the test was added more than 10 years ago. Bug: 594672 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I24264f86ce1dcebdac2a6a9f912d3b292d39bdc0 Reviewed-on: https://chromium-review.googlesource.com/1113310 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#570761} [modify] https://crrev.com/e8f2c12152620b145329a0125b7510feb86858b5/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/e8f2c12152620b145329a0125b7510feb86858b5/third_party/WebKit/LayoutTests/fast/events/scale-and-scroll-iframe-body-expected.png [modify] https://crrev.com/e8f2c12152620b145329a0125b7510feb86858b5/third_party/WebKit/LayoutTests/fast/events/scale-and-scroll-iframe-body.html [modify] https://crrev.com/e8f2c12152620b145329a0125b7510feb86858b5/third_party/WebKit/LayoutTests/fast/events/updateLayoutForHitTest.html [modify] https://crrev.com/e8f2c12152620b145329a0125b7510feb86858b5/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/events/updateLayoutForHitTest-expected.png [modify] https://crrev.com/e8f2c12152620b145329a0125b7510feb86858b5/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/events/updateLayoutForHitTest-expected.txt [delete] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/mouseevent_fractional/fast/events/updateLayoutForHitTest-expected.png [delete] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/mouseevent_fractional/fast/events/updateLayoutForHitTest-expected.txt [modify] https://crrev.com/e8f2c12152620b145329a0125b7510feb86858b5/third_party/WebKit/LayoutTests/platform/linux/fast/events/updateLayoutForHitTest-expected.png [modify] https://crrev.com/e8f2c12152620b145329a0125b7510feb86858b5/third_party/WebKit/LayoutTests/platform/linux/fast/events/updateLayoutForHitTest-expected.txt [delete] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/platform/linux/virtual/pointerevent/fast/events/updateLayoutForHitTest-expected.png [delete] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/platform/mac/fast/events/iframe-object-onload-expected.txt [modify] https://crrev.com/e8f2c12152620b145329a0125b7510feb86858b5/third_party/WebKit/LayoutTests/platform/mac/fast/events/updateLayoutForHitTest-expected.png [modify] https://crrev.com/e8f2c12152620b145329a0125b7510feb86858b5/third_party/WebKit/LayoutTests/platform/mac/fast/events/updateLayoutForHitTest-expected.txt [delete] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/platform/mac/virtual/pointerevent/fast/events/updateLayoutForHitTest-expected.png [modify] https://crrev.com/e8f2c12152620b145329a0125b7510feb86858b5/third_party/WebKit/LayoutTests/platform/win/fast/events/updateLayoutForHitTest-expected.png [modify] https://crrev.com/e8f2c12152620b145329a0125b7510feb86858b5/third_party/WebKit/LayoutTests/platform/win/fast/events/updateLayoutForHitTest-expected.txt [delete] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/platform/win/virtual/pointerevent/fast/events/updateLayoutForHitTest-expected.png [add] https://crrev.com/e8f2c12152620b145329a0125b7510feb86858b5/third_party/WebKit/LayoutTests/platform/win7/fast/events/updateLayoutForHitTest-expected.png [add] https://crrev.com/e8f2c12152620b145329a0125b7510feb86858b5/third_party/WebKit/LayoutTests/platform/win7/fast/events/updateLayoutForHitTest-expected.txt
,
Jun 27 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nzolghadr@chromium.org
, Mar 14 2016