New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594669 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Stop using the aggressive buffering strategy for media when paused.

Project Member Reported by dalecur...@chromium.org, Mar 14 2016

Issue description

This was enabled on Android as a consequence of Project-Spitzer, but does not match the platform behavior and may have unintended consequences on data usage, so step 1 is to disable this behavior on Android (where it has never existed).

Step 2 is to evaluate whether this is actually a feature we even want on desktop anymore. We should add some UMA statistics about how frequently pause-buffer triggers and is later played. Perhaps through some efficiency measure of bytes downloaded to bytes consumed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37fe586e648a966438f0b26473155cba830d497e

commit 37fe586e648a966438f0b26473155cba830d497e
Author: dalecurtis <dalecurtis@chromium.org>
Date: Tue Mar 15 19:29:09 2016

Disable "pause-and-buffer" on Android, cancel suspended players.

The Android MediaPlayer never supported "pause-and-buffer" so to
avoid unexpected behavior on metered networks, disable this feature
for WebMediaPlayerImpl as well.

This also releases the network connection for suspended instances
of WebMediaPlayerImpl. Due to "pause-and-buffer" on non-Android
platforms only instances that the user has never interacted with
(i.e. they have not played and then paused the player) will be
released. On Android, all suspended players will lose their
network connection after reaches the deferred state.

BUG= 594669 
TEST=new unittests, verified connection is closed manually.

Review URL: https://codereview.chromium.org/1798213002

Cr-Commit-Position: refs/heads/master@{#381280}

[modify] https://crrev.com/37fe586e648a966438f0b26473155cba830d497e/media/blink/buffered_data_source.cc
[modify] https://crrev.com/37fe586e648a966438f0b26473155cba830d497e/media/blink/buffered_data_source.h
[modify] https://crrev.com/37fe586e648a966438f0b26473155cba830d497e/media/blink/buffered_data_source_unittest.cc
[modify] https://crrev.com/37fe586e648a966438f0b26473155cba830d497e/media/blink/multibuffer_data_source.cc
[modify] https://crrev.com/37fe586e648a966438f0b26473155cba830d497e/media/blink/multibuffer_data_source.h
[modify] https://crrev.com/37fe586e648a966438f0b26473155cba830d497e/media/blink/multibuffer_data_source_unittest.cc
[modify] https://crrev.com/37fe586e648a966438f0b26473155cba830d497e/media/blink/webmediaplayer_impl.cc

 issue 595232  arose out of this and contains a fix needed for this patch if we merge it.
Labels: Merge-Request-50

Comment 4 by tin...@google.com, Mar 18 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Merge includes http://crrev.com/381474.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 19 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cec74ffcf0ffab45ec51ac48d49dda4489c88b04

commit cec74ffcf0ffab45ec51ac48d49dda4489c88b04
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Sat Mar 19 00:17:35 2016

Merge M50: "Disable "pause-and-buffer" on Android, cancel suspended players."

The Android MediaPlayer never supported "pause-and-buffer" so to
avoid unexpected behavior on metered networks, disable this feature
for WebMediaPlayerImpl as well.

This also releases the network connection for suspended instances
of WebMediaPlayerImpl. Due to "pause-and-buffer" on non-Android
platforms only instances that the user has never interacted with
(i.e. they have not played and then paused the player) will be
released. On Android, all suspended players will lose their
network connection after reaches the deferred state.

BUG= 594669 
TEST=new unittests, verified connection is closed manually.

Review URL: https://codereview.chromium.org/1798213002

Cr-Commit-Position: refs/heads/master@{#381280}
(cherry picked from commit 37fe586e648a966438f0b26473155cba830d497e)

Review URL: https://codereview.chromium.org/1815893002 .

Cr-Commit-Position: refs/branch-heads/2661@{#296}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/cec74ffcf0ffab45ec51ac48d49dda4489c88b04/media/blink/buffered_data_source.cc
[modify] https://crrev.com/cec74ffcf0ffab45ec51ac48d49dda4489c88b04/media/blink/buffered_data_source.h
[modify] https://crrev.com/cec74ffcf0ffab45ec51ac48d49dda4489c88b04/media/blink/buffered_data_source_unittest.cc
[modify] https://crrev.com/cec74ffcf0ffab45ec51ac48d49dda4489c88b04/media/blink/multibuffer_data_source.cc
[modify] https://crrev.com/cec74ffcf0ffab45ec51ac48d49dda4489c88b04/media/blink/multibuffer_data_source.h
[modify] https://crrev.com/cec74ffcf0ffab45ec51ac48d49dda4489c88b04/media/blink/multibuffer_data_source_unittest.cc
[modify] https://crrev.com/cec74ffcf0ffab45ec51ac48d49dda4489c88b04/media/blink/webmediaplayer_impl.cc

Status: Fixed (was: Assigned)

Sign in to add a comment