New issue
Advanced search Search tips

Issue 594660 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 597789



Sign in to add a comment

Blimp 0.5 client: Make usable as default browser

Project Member Reported by mdw@chromium.org, Mar 14 2016

Issue description

With a small amount of work, it should be possible to use the Blimp client as the default browser on the user's device. This would be really useful for day-to-day use, while still allowing a page to be opened in Chrome when needed.

- Ensure that the Blimp client can receive the intent to open URLs.
- Have an "open in Chrome" option in a three-dots menu (similar to how Chrome Custom Tabs works today) to open the current page in Chrome.


 
Cc: dtrainor@chromium.org
Owner: shaktisahu@chromium.org

Comment 2 by w...@chromium.org, Mar 22 2016

Components: Mobile>Blimp>Client
Labels: -Proj-Blimp
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aadad4d568976931a377f567f25b93458a2530c

commit 4aadad4d568976931a377f567f25b93458a2530c
Author: shaktisahu <shaktisahu@chromium.org>
Date: Fri Apr 01 01:03:14 2016

Added support to blimp to be usable as a default browser

Currently blimp cannot be launched from other applications i.e. blimp doesn't
show up as one of the browser options when user taps on an URL. This CL enables
blimp to be a default browser which can handle http:// and https:// URL schemes.
Intent is handled at the beginning of the application and also on any subsequent
onNewIntent call.

BUG= 594660 

Review URL: https://codereview.chromium.org/1814693003

Cr-Commit-Position: refs/heads/master@{#384455}

[modify] https://crrev.com/4aadad4d568976931a377f567f25b93458a2530c/blimp/client/app/android/AndroidManifest.xml.jinja2
[modify] https://crrev.com/4aadad4d568976931a377f567f25b93458a2530c/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java

Blocking: 597789
Labels: -Type-Bug M-52 Type-Feature
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c3b4e2d3c6444dea2d2e8c238c0e16263813c33

commit 3c3b4e2d3c6444dea2d2e8c238c0e16263813c33
Author: shaktisahu <shaktisahu@chromium.org>
Date: Fri Apr 01 16:59:50 2016

Added menu button to blimp toolbar

This is the three dots menu similar to Chrome. Added "Open in Chrome" option to this menu.

BUG= 594660 

Review URL: https://codereview.chromium.org/1841653005

Cr-Commit-Position: refs/heads/master@{#384612}

[add] https://crrev.com/3c3b4e2d3c6444dea2d2e8c238c0e16263813c33/blimp/client/app/android/java/res/drawable-hdpi/btn_menu.png
[add] https://crrev.com/3c3b4e2d3c6444dea2d2e8c238c0e16263813c33/blimp/client/app/android/java/res/drawable-mdpi/btn_menu.png
[add] https://crrev.com/3c3b4e2d3c6444dea2d2e8c238c0e16263813c33/blimp/client/app/android/java/res/drawable-xhdpi/btn_menu.png
[add] https://crrev.com/3c3b4e2d3c6444dea2d2e8c238c0e16263813c33/blimp/client/app/android/java/res/drawable-xxhdpi/btn_menu.png
[add] https://crrev.com/3c3b4e2d3c6444dea2d2e8c238c0e16263813c33/blimp/client/app/android/java/res/drawable-xxxhdpi/btn_menu.png
[modify] https://crrev.com/3c3b4e2d3c6444dea2d2e8c238c0e16263813c33/blimp/client/app/android/java/res/layout/blimp_main.xml
[add] https://crrev.com/3c3b4e2d3c6444dea2d2e8c238c0e16263813c33/blimp/client/app/android/java/res/layout/toolbar_popup_item.xml
[add] https://crrev.com/3c3b4e2d3c6444dea2d2e8c238c0e16263813c33/blimp/client/app/android/java/res/values/colors.xml
[add] https://crrev.com/3c3b4e2d3c6444dea2d2e8c238c0e16263813c33/blimp/client/app/android/java/res/values/dimens.xml
[modify] https://crrev.com/3c3b4e2d3c6444dea2d2e8c238c0e16263813c33/blimp/client/app/android/java/src/org/chromium/blimp/toolbar/Toolbar.java
[modify] https://crrev.com/3c3b4e2d3c6444dea2d2e8c238c0e16263813c33/blimp/client/app/android/java/strings/android_blimp_strings.grd

Status: Fixed (was: Assigned)
Labels: Archive-Blimp

Sign in to add a comment