BrowserNonClientFrameViewAsh::NonClientHitTest() should call BrowserView::IsTabStripVisible() |
|||
Issue descriptionBrowserNonClientFrameViewAsh::NonClientHitTest() as well as BrowserNonClientFrameViewMus::NonClientHitTest() should call BrowserView::IsTabStripVisible() prior to calling through to browser_view()->tabstrip()->bounds(). It may be the case that the tabstrip is null, or that the window type does not support showing a tabstrip.
,
Aug 9 2017
Peter/Scott, could you help in re-triaging this?
,
Aug 10 2017
This code still exists. Notably, however, the glass/opaque frames don't look at the tabstrip bounds at all. I suspect they're more trustworthy than the mus/ash code. I wonder if kTabShadowHeight referenced in mus/ash even corresponds to anything visible anymore with top-chrome-MD. Is there a shadow above the tabs on ash? bsep and estade have touched/refactored the frame code more recently than me. Getting to the point of unifying this function across frames would be good, but even before then, if we discover the tabstrip "top shadow" doesn't actually correspond to anything, maybe we just nuke this conditional. |
|||
►
Sign in to add a comment |
|||
Comment 1 by tdander...@chromium.org
, Apr 13 2016