New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594649 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug

Blocking:
issue 594651
issue 595028



Sign in to add a comment

Check for null |tabstrip_| in BrowserView::IsTabStripVisible()

Project Member Reported by tdander...@chromium.org, Mar 14 2016

Issue description

Have BrowserView::IsTabStripVisible() return false if |tabstrip_| is null, which is consistent with the behaviour of other BrowserView::Is*Visible() functions.

 
Labels: M-51
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b4aaba68babcfcee3887c04cc5397e6d5755450

commit 9b4aaba68babcfcee3887c04cc5397e6d5755450
Author: tdanderson <tdanderson@chromium.org>
Date: Tue Mar 15 16:59:41 2016

Check for null |tabstrip_| in BrowserView::IsTabStripVisible()

Have BrowserView::IsTabStripVisible() return false
if |tabstrip_| is null, which is consistent with the
behaviour of other BrowserView::Is*Visible() functions.

BUG= 594649 
TEST=none

Review URL: https://codereview.chromium.org/1780333006

Cr-Commit-Position: refs/heads/master@{#381235}

[modify] https://crrev.com/9b4aaba68babcfcee3887c04cc5397e6d5755450/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/9b4aaba68babcfcee3887c04cc5397e6d5755450/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc
[modify] https://crrev.com/9b4aaba68babcfcee3887c04cc5397e6d5755450/chrome/browser/ui/views/frame/browser_view.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment