New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 594636 link

Starred by 1 user
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Mar 2016
Cc:
█ ben@chromium.org
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

mash_shell black screen and views_mus_unittests failures.

Project Member Reported by msw@chromium.org, Mar 14 2016 
mash_shell black screen and views_mus_unittests failures.

1st test failure: https://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Windows/builds/17797
All the failures are crashes in mus::ws::DefaultPlatformDisplay::Draw
Suspicious CL: https://codereview.chromium.org/1793793002

This CL also makes mash_shell render completely black on Linux desktop.
When syncing to that CL (35f7270e84da5abb0f7895304a53d632efbbfe71) "chrome --mash" draws black.
When syncing one CL prior (f749fe6715f1f3c81bda3576fd60f260ac47282a) "chrome --mash" draws normally.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27eb4409b17331235123e5e0a6837aa760203816

commit 27eb4409b17331235123e5e0a6837aa760203816
Author: rockot <rockot@chromium.org>
Date: Tue Mar 15 05:57:59 2016

Reinstate wait-for-Initialize when Chrome is run in Mash

Mus Views needs to completely block the main thread during
initialization, including any pending tasks. This means
incoming messages on any other pipe will never be dispatched.
If ShellClient::Initialize is blocked, the pipe views is
waiting on will in turn never be able to signal, resulting
in an effective deadlock.

So we need to wait for Initialize before proceeding with the
rest of the main thread setup. This adds a temporary switch
to explicitly opt in to wait-for-Initialize behavior on
MojoShellConnection, and adds that switch when running in mash.

BUG= 594636 ,594852
TEST=views_mus_unittests, mus_ws_unittests, and chrome --mash renders as well as it did before I broke it.

Review URL: https://codereview.chromium.org/1797153002

Cr-Commit-Position: refs/heads/master@{#381182}

[modify] https://crrev.com/27eb4409b17331235123e5e0a6837aa760203816/chrome/app/mash/mash_runner.cc
[modify] https://crrev.com/27eb4409b17331235123e5e0a6837aa760203816/content/common/mojo/mojo_shell_connection_impl.cc
[modify] https://crrev.com/27eb4409b17331235123e5e0a6837aa760203816/content/common/mojo/mojo_shell_connection_impl.h
[modify] https://crrev.com/27eb4409b17331235123e5e0a6837aa760203816/content/public/common/content_switches.cc
[modify] https://crrev.com/27eb4409b17331235123e5e0a6837aa760203816/content/public/common/content_switches.h
[modify] https://crrev.com/27eb4409b17331235123e5e0a6837aa760203816/mojo/edk/embedder/embedder.cc
[modify] https://crrev.com/27eb4409b17331235123e5e0a6837aa760203816/mojo/shell/public/cpp/lib/shell_connection.cc
[modify] https://crrev.com/27eb4409b17331235123e5e0a6837aa760203816/mojo/shell/public/cpp/shell_connection.h
[modify] https://crrev.com/27eb4409b17331235123e5e0a6837aa760203816/ui/views/mus/platform_test_helper_mus.cc
[modify] https://crrev.com/27eb4409b17331235123e5e0a6837aa760203816/ui/views/mus/screen_mus.cc
[modify] https://crrev.com/27eb4409b17331235123e5e0a6837aa760203816/ui/views/mus/screen_mus.h

Comment 2 by roc...@chromium.org, Mar 15 2016

Status: Fixed (was: Assigned)

Comment 3 by lafo...@chromium.org, Feb 26 2018

Components: -MUS Internals>Services>WindowService
►

Sign in to add a comment