New issue
Advanced search Search tips

Issue 594605 link

Starred by 2 users
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Mar 2016
Cc:
simonhatch@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Bisect FYI jobs failed while resolving revision range

Project Member Reported by pras...@chromium.org, Mar 14 2016 
All bisect fyi jobs failed while resolving revision range.;

https://build.chromium.org/p/tryserver.chromium.perf/builders/android_fyi_perf_bisect/builds/196/steps/steps/logs/stdio

@@@STEP_NEST_LEVEL@1@@@
Traceback (most recent call last):
  File "/b/build/scripts/slave/recipe_modules/crrev/resources/crrev_client.py", line 77, in <module>
    main()
  File "/b/build/scripts/slave/recipe_modules/crrev/resources/crrev_client.py", line 72, in main
    params = json.lad(args.params_file)
AttributeError: 'module' object has no attribute 'lad'
step returned non-zero exit code: 1
@@@STEP_LOG_LINE@json.output (invalid)@null@@@
@@@STEP_LOG_END@json.output (invalid)@@@
@@@STEP_FAILURE@@@
@@@SET_BUILD_PROPERTY@extra_result_code@["B4T_BAD_REV"]@@@
@@@STEP_CLOSED@@@
@@@STEP_CURSOR@Resolving reference range@@@

Comment 1 by qyears...@chromium.org, Mar 14 2016 

Ahrg, thanks for finding the failure -- seems like just a simple typo, I wonder why it wasn't caught by any presubmits... must not have test coverage.

A revert was made of the CL to use crrev in https://codereview.chromium.org/1801843002/

Comment 2 by pras...@chromium.org, Mar 15 2016 

Issue 594724 has been merged into this issue.

Comment 3 by pras...@chromium.org, Mar 16 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/fbd95b4f7be5d9c5ac0e5cd3c1b7ea1a923a7163

commit fbd95b4f7be5d9c5ac0e5cd3c1b7ea1a923a7163
Author: qyearsley@chromium.org <qyearsley@chromium.org>
Date: Tue Mar 29 16:33:33 2016

Fix crrev and add test coverage for the main function.

Specifically, what was broken was a simple typo: json.lad instead of json.load. I didn't catch this before because there was no test coverage for the `main` function.

BUG= 594605 

Review URL: https://codereview.chromium.org/1796993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299538 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/fbd95b4f7be5d9c5ac0e5cd3c1b7ea1a923a7163/scripts/slave/recipe_modules/crrev/resources/crrev_client.py
[modify] https://crrev.com/fbd95b4f7be5d9c5ac0e5cd3c1b7ea1a923a7163/scripts/slave/recipe_modules/crrev/resources/crrev_client_test.py
[add] https://crrev.com/fbd95b4f7be5d9c5ac0e5cd3c1b7ea1a923a7163/scripts/slave/recipe_modules/crrev/resources/test_params_file.json

Comment 5 by benhenry@chromium.org, Feb 3 2017

Components: Speed>Bisection
►

Sign in to add a comment