New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594601 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature



Sign in to add a comment

[Cronet] Add experimental host-resolver-rules to CronetEngine Builder

Project Member Reported by mef@chromium.org, Mar 14 2016

Issue description

We need to steer requests to a particular GFE.

This will be needed for early GRPC end-to-end demos until server changes gets widely deployed. 

We need --host-resolver-rules equivalent in CronetEngine which would take care of this.

Look at CreateGlobalHostResolverRules in IOThread. We should do the same here.
 
Miriam, thanks for doing this. Let me know what I help. To plumb a experimental flag from Cronet to net::, it would be similar to https://codereview.chromium.org/1796253002/.
I don't know if an experimental flag will work for this case?

I was thinking in general it would be something where we change the HostResolver tied to the HttpNetworkSession to be a MappedHostResolver when these options are set.
I was assuming we need this temporarily only for BidirectionalStream QUIC, so we wouldn't want a real API for it.

Why do we need custom host resolver mapping for this? Don't they have a different url for their staging test server?
Had a quick chat with Helen. She did express concerns about implementing an API that would be used for testing purposes only.

Comment 5 by sidv@chromium.org, May 27 2016

I am doing some housekeeping on bugs and noticed that this one was tagged as M51. Should we close this ? 

Comment 6 by mge...@chromium.org, May 27 2016

Labels: -M-51
No, it's still relevant, sorry. I removed the milestone.

Comment 7 by sidv@chromium.org, Jun 13 2016

Labels: M-53
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 15 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af2c12c7e4968c60f39b33e8244429146447f3a5

commit af2c12c7e4968c60f39b33e8244429146447f3a5
Author: mgersh <mgersh@chromium.org>
Date: Mon Aug 22 16:33:54 2016

Add host resolver rules experimental flag for Cronet

This option allows Cronet embedders to do end-to-end testing which
requires pointing requests to a particular test server.

BUG= 594601 

Review-Url: https://codereview.chromium.org/1817553002
Cr-Commit-Position: refs/heads/master@{#413454}

[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/test/cronet_test_util.cc
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/test/cronet_test_util.h
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/test/javatests/src/org/chromium/net/SdchTest.java
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/test/native_test_server.cc
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/test/quic_test_server.cc
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/test/src/org/chromium/net/CronetTestUtil.java
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/test/src/org/chromium/net/NativeTestServer.java
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/test/src/org/chromium/net/QuicTestServer.java
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/android/url_request_context_adapter.cc
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/url_request_context_config.cc
[modify] https://crrev.com/af2c12c7e4968c60f39b33e8244429146447f3a5/components/cronet/url_request_context_config_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment