New issue
Advanced search Search tips

Issue 594600 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Test suite that can run browser tests inside mustash

Project Member Reported by sky@chromium.org, Mar 14 2016

Issue description

We need the ability to run browsertests inside a mustash environment.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bacaa54b061311fa959a9763038a69e4df55b34d

commit bacaa54b061311fa959a9763038a69e4df55b34d
Author: sky <sky@chromium.org>
Date: Thu Apr 07 21:34:19 2016

Add switch to mash's browser_tests

This is needed for the time being as mus doesn't support a software
compositor.

BUG= 600802 ,  594600 ,  594600 
TEST=none
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1869133002

Cr-Commit-Position: refs/heads/master@{#385876}

[modify] https://crrev.com/bacaa54b061311fa959a9763038a69e4df55b34d/testing/buildbot/chromium.mojo.json
[modify] https://crrev.com/bacaa54b061311fa959a9763038a69e4df55b34d/testing/buildbot/gn_isolate_map.pyl

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19679c126ac50358ace8db3cccb6b778e9340ab1

commit 19679c126ac50358ace8db3cccb6b778e9340ab1
Author: sky <sky@chromium.org>
Date: Fri Apr 08 17:08:28 2016

Update browser_tests on chromium.mojo.fyi bot

Apparently this is needed as the bot doesn't use swarming.

BUG= 600802 ,  594600 ,  594600 
TEST=none
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1873863003

Cr-Commit-Position: refs/heads/master@{#386107}

[modify] https://crrev.com/19679c126ac50358ace8db3cccb6b778e9340ab1/testing/buildbot/chromium.mojo.json
[modify] https://crrev.com/19679c126ac50358ace8db3cccb6b778e9340ab1/testing/buildbot/gn_isolate_map.pyl

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ccb5f15535dcf49a334cdb4a00ad4a11b72ae76

commit 6ccb5f15535dcf49a334cdb4a00ad4a11b72ae76
Author: sky <sky@chromium.org>
Date: Fri Apr 08 21:03:14 2016

Makes browser_tests depend upon mojo manifests

These are read for browser_tests.

BUG= 594600 
TEST=none
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/1876493002

Cr-Commit-Position: refs/heads/master@{#386196}

[modify] https://crrev.com/6ccb5f15535dcf49a334cdb4a00ad4a11b72ae76/chrome/app/BUILD.gn
[modify] https://crrev.com/6ccb5f15535dcf49a334cdb4a00ad4a11b72ae76/chrome/test/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bee374bf24e72d354da2d76c668668f90589b8a1

commit bee374bf24e72d354da2d76c668668f90589b8a1
Author: sky <sky@chromium.org>
Date: Thu Apr 14 16:59:58 2016

Add switch for mojo tests

Hopefully this makes them start working.

BUG= 594600 
TEST=none
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1887853003

Cr-Commit-Position: refs/heads/master@{#387341}

[modify] https://crrev.com/bee374bf24e72d354da2d76c668668f90589b8a1/testing/buildbot/chromium.mojo.json

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f24fa9e0a4869c45515161d24a5c4086b648fe2b

commit f24fa9e0a4869c45515161d24a5c4086b648fe2b
Author: sky <sky@chromium.org>
Date: Thu Apr 14 21:52:56 2016

Adds logging code to help figure out why test is crashing on bot

Test is timing out with error of -1. I can't repro locally, so I'm
hoping this will shed some light on how far things are getting.

BUG= 594600 
TEST=none
R=msw@chromium.org

Review URL: https://codereview.chromium.org/1888203002

Cr-Commit-Position: refs/heads/master@{#387438}

[modify] https://crrev.com/f24fa9e0a4869c45515161d24a5c4086b648fe2b/chrome/test/base/mash_browser_tests_main.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21a7c114f9295ed01bec336c6068d34e3a561614

commit 21a7c114f9295ed01bec336c6068d34e3a561614
Author: sky <sky@chromium.org>
Date: Thu Apr 14 23:59:09 2016

Adds logging code to help figure out why test is crashing on bot

Test is timing out with error of -1. I can't repro locally, so I'm
hoping this will shed some light on how far things are getting.

BUG= 594600 
TEST=none
R=msw@chromium.org

Review URL: https://codereview.chromium.org/1887283002

Cr-Commit-Position: refs/heads/master@{#387480}

[modify] https://crrev.com/21a7c114f9295ed01bec336c6068d34e3a561614/chrome/test/base/mash_browser_tests_main.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02bf716e8ebff39a2a8c0230bfa621bdbec24683

commit 02bf716e8ebff39a2a8c0230bfa621bdbec24683
Author: sky <sky@chromium.org>
Date: Thu Apr 21 04:56:16 2016

Makes ScreenMus not check that displays are non-empty

WaitForIncomingMethodCall can return in the case of the pipe being
broken (say mus is going down). Adds code to handle that case.

BUG= 594600 
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1912523002

Cr-Commit-Position: refs/heads/master@{#388696}

[modify] https://crrev.com/02bf716e8ebff39a2a8c0230bfa621bdbec24683/ui/views/mus/screen_mus.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6523ddafa66f46477ab87cbca0f50bb744c813c3

commit 6523ddafa66f46477ab87cbca0f50bb744c813c3
Author: kjellander <kjellander@chromium.org>
Date: Thu Apr 21 07:50:28 2016

Revert of Makes ScreenMus not check that displays are non-empty (patchset #1 id:1 of https://codereview.chromium.org/1912523002/ )

Reason for revert:
Speculative revert for failing interactive_ui_tests on Linux Chromium OS ASan LSan Tests (1), starting with
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/11887

Failure:
[ RUN      ] DragDropTest.DragDropAcrossMultiDisplay
Xlib:  extension "RANDR" missing on display ":9".
[9809:9809:0420/230942:21040728698:INFO:lock_state_controller.cc(95)] Constructing LockStateController instance 0x61600006c980
Xlib:  extension "RANDR" missing on display ":9".
../../ash/drag_drop/drag_drop_interactive_uitest.cc:153: Failure
Value of: target_view->dropped()
  Actual: false
Expected: true
[9809:9809:0420/230942:21040854605:INFO:lock_state_controller.cc(101)] Destroying LockStateController instance 0x61600006c980
[  FAILED  ] DragDropTest.DragDropAcrossMultiDisplay (231 ms)

Original issue's description:
> Makes ScreenMus not check that displays are non-empty
>
> WaitForIncomingMethodCall can return in the case of the pipe being
> broken (say mus is going down). Adds code to handle that case.
>
> BUG= 594600 
> TEST=none
> R=ben@chromium.org

TBR=ben@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 594600 

Review URL: https://codereview.chromium.org/1905893002

Cr-Commit-Position: refs/heads/master@{#388714}

[modify] https://crrev.com/6523ddafa66f46477ab87cbca0f50bb744c813c3/ui/views/mus/screen_mus.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0549569cece757249c77ebee22bb995d8ffb985

commit d0549569cece757249c77ebee22bb995d8ffb985
Author: kjellander <kjellander@chromium.org>
Date: Thu Apr 21 10:38:15 2016

Reland of Makes ScreenMus not check that displays are non-empty (patchset #1 id:1 of https://codereview.chromium.org/1905893002/ )

Reason for revert:
Relanding since the revert did not green up the test.

Original issue's description:
> Revert of Makes ScreenMus not check that displays are non-empty (patchset #1 id:1 of https://codereview.chromium.org/1912523002/ )
>
> Reason for revert:
> Speculative revert for failing interactive_ui_tests on Linux Chromium OS ASan LSan Tests (1), starting with
> https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/11887
>
> Failure:
> [ RUN      ] DragDropTest.DragDropAcrossMultiDisplay
> Xlib:  extension "RANDR" missing on display ":9".
> [9809:9809:0420/230942:21040728698:INFO:lock_state_controller.cc(95)] Constructing LockStateController instance 0x61600006c980
> Xlib:  extension "RANDR" missing on display ":9".
> ../../ash/drag_drop/drag_drop_interactive_uitest.cc:153: Failure
> Value of: target_view->dropped()
>   Actual: false
> Expected: true
> [9809:9809:0420/230942:21040854605:INFO:lock_state_controller.cc(101)] Destroying LockStateController instance 0x61600006c980
> [  FAILED  ] DragDropTest.DragDropAcrossMultiDisplay (231 ms)
>
>
> Original issue's description:
> > Makes ScreenMus not check that displays are non-empty
> >
> > WaitForIncomingMethodCall can return in the case of the pipe being
> > broken (say mus is going down). Adds code to handle that case.
> >
> > BUG= 594600 
> > TEST=none
> > R=ben@chromium.org
>
> TBR=ben@chromium.org,sky@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 594600 

TBR=ben@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 594600 

Review URL: https://codereview.chromium.org/1905873003

Cr-Commit-Position: refs/heads/master@{#388735}

[modify] https://crrev.com/d0549569cece757249c77ebee22bb995d8ffb985/ui/views/mus/screen_mus.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8d418d3c26048ed54ce7039bcc4c627a6804c54

commit b8d418d3c26048ed54ce7039bcc4c627a6804c54
Author: sky <sky@chromium.org>
Date: Mon Apr 25 18:26:03 2016

Fixes possible deadlock in fontservice

Here's the sequence:
1. FontServiceThread::OpenStreamImpl
2. FontService::OpenStream
3. FontServiceThread::OnOpenStreamComplete

If between 2 and 3 FontService gets a connection error the callback
that calls OnOpenStreamComplete is never received, and the thread that
called OpenStream() is stuck forever.

Fix is to add the WaitableEvents to a member variable and if a
connection error is received all WaitableEvents are signaled.

BUG= 594600 
TEST=none
R=erg@chromium.org

Review URL: https://codereview.chromium.org/1916003002

Cr-Commit-Position: refs/heads/master@{#389515}

[modify] https://crrev.com/b8d418d3c26048ed54ce7039bcc4c627a6804c54/components/font_service/public/cpp/font_service_thread.cc
[modify] https://crrev.com/b8d418d3c26048ed54ce7039bcc4c627a6804c54/components/font_service/public/cpp/font_service_thread.h

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8d418d3c26048ed54ce7039bcc4c627a6804c54

commit b8d418d3c26048ed54ce7039bcc4c627a6804c54
Author: sky <sky@chromium.org>
Date: Mon Apr 25 18:26:03 2016

Fixes possible deadlock in fontservice

Here's the sequence:
1. FontServiceThread::OpenStreamImpl
2. FontService::OpenStream
3. FontServiceThread::OnOpenStreamComplete

If between 2 and 3 FontService gets a connection error the callback
that calls OnOpenStreamComplete is never received, and the thread that
called OpenStream() is stuck forever.

Fix is to add the WaitableEvents to a member variable and if a
connection error is received all WaitableEvents are signaled.

BUG= 594600 
TEST=none
R=erg@chromium.org

Review URL: https://codereview.chromium.org/1916003002

Cr-Commit-Position: refs/heads/master@{#389515}

[modify] https://crrev.com/b8d418d3c26048ed54ce7039bcc4c627a6804c54/components/font_service/public/cpp/font_service_thread.cc
[modify] https://crrev.com/b8d418d3c26048ed54ce7039bcc4c627a6804c54/components/font_service/public/cpp/font_service_thread.h

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23d9fc09311539a683d1c6303a92d4fa6b1663cc

commit 23d9fc09311539a683d1c6303a92d4fa6b1663cc
Author: sadrul <sadrul@chromium.org>
Date: Wed Apr 27 13:50:17 2016

mash/browser-tests: Use the correct test-flag for browser-test.

'--use-x11-test-config' flag was replaced by '--use-test-config' in
https://crrev.com/388329, but it missed updating the flag used when running
browser-tests in mash.

BUG= 594600 

Review URL: https://codereview.chromium.org/1914283003

Cr-Commit-Position: refs/heads/master@{#390060}

[modify] https://crrev.com/23d9fc09311539a683d1c6303a92d4fa6b1663cc/testing/buildbot/chromium.mojo.json

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f93523a0983f155818e81610f07b0250c32488ea

commit f93523a0983f155818e81610f07b0250c32488ea
Author: sadrul <sadrul@chromium.org>
Date: Thu Apr 28 04:54:27 2016

mus/views: Call to WaitForIncomingMethodCall() can fail.

If the ShellConnection never made a valid connection, then the
WaitForIncomingMethodCall() returns false, but the ipc-endpoints
may not have encountered any errors [yet].

BUG= 594600 

Review-Url: https://codereview.chromium.org/1928733002
Cr-Commit-Position: refs/heads/master@{#390302}

[modify] https://crrev.com/f93523a0983f155818e81610f07b0250c32488ea/ui/views/mus/screen_mus.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c31552d35ecc9d8832b9fb88f1da52b1c517ca66

commit c31552d35ecc9d8832b9fb88f1da52b1c517ca66
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Fri Apr 29 01:18:09 2016

font-service: Track one more pending WaitableEvent.

BUG= 594600 
R=erg@chromium.org

Review URL: https://codereview.chromium.org/1925423002 .

Cr-Commit-Position: refs/heads/master@{#390555}

[modify] https://crrev.com/c31552d35ecc9d8832b9fb88f1da52b1c517ca66/components/font_service/public/cpp/font_service_thread.cc

Project Member

Comment 16 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd59809a77388530bdc617ec0ed3bdf3919f35da

commit cd59809a77388530bdc617ec0ed3bdf3919f35da
Author: sadrul <sadrul@chromium.org>
Date: Mon May 02 17:24:52 2016

mash/chrome: Update manifest for exe:chrome.

Make sure exe:chrome declares 'app' class. Fix //services/shell
to erase just the '*' from the requested interfaces if target
requested shell:explicit_class, instead of overriding the other
explicit interface requests.

BUG= 594600 

Review-Url: https://codereview.chromium.org/1930813002
Cr-Commit-Position: refs/heads/master@{#390980}

[modify] https://crrev.com/cd59809a77388530bdc617ec0ed3bdf3919f35da/chrome/app/BUILD.gn
[modify] https://crrev.com/cd59809a77388530bdc617ec0ed3bdf3919f35da/chrome/app/mojo/chrome_manifest.json
[modify] https://crrev.com/cd59809a77388530bdc617ec0ed3bdf3919f35da/services/shell/shell.cc

Project Member

Comment 17 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8376db0747208ba10bdc333c0262a025cd792ee6

commit 8376db0747208ba10bdc333c0262a025cd792ee6
Author: sky <sky@chromium.org>
Date: Tue May 03 18:00:45 2016

Makes BitmapUploader early out if error encountered

This avoids a CHECK in trying to use gl functions.

BUG= 594600 
TEST=none
R=fsamuel@chromium.org

Review-Url: https://codereview.chromium.org/1942063002
Cr-Commit-Position: refs/heads/master@{#391292}

[modify] https://crrev.com/8376db0747208ba10bdc333c0262a025cd792ee6/components/bitmap_uploader/bitmap_uploader.cc

Project Member

Comment 18 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53b25adab2383775bffb34a2c5e266b6375898de

commit 53b25adab2383775bffb34a2c5e266b6375898de
Author: sadrul <sadrul@chromium.org>
Date: Fri May 20 16:36:24 2016

mash: Fix a mash_browser_tests crash on x11.

When running as a mus-client, chrome receives from mus, and not from x11.
So the X11EventSource instance is not created.

BUG= 594600 

Review-Url: https://codereview.chromium.org/1996413002
Cr-Commit-Position: refs/heads/master@{#395094}

[modify] https://crrev.com/53b25adab2383775bffb34a2c5e266b6375898de/chrome/browser/chrome_browser_main_extra_parts_x11.cc

Project Member

Comment 19 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd1cc4c7b4cb560f2fd7d23ac9f4ebf005f88e44

commit fd1cc4c7b4cb560f2fd7d23ac9f4ebf005f88e44
Author: erg <erg@chromium.org>
Date: Fri May 20 18:58:04 2016

mash: Fix mash in debug builds.

X11EventSource::GetInstance() would DCHECK if it had no instance. Add a
dedicated bool returning checker function and use it where we were
crashing.

BUG= 594600 

Review-Url: https://codereview.chromium.org/2004533002
Cr-Commit-Position: refs/heads/master@{#395125}

[modify] https://crrev.com/fd1cc4c7b4cb560f2fd7d23ac9f4ebf005f88e44/chrome/browser/chrome_browser_main_extra_parts_x11.cc
[modify] https://crrev.com/fd1cc4c7b4cb560f2fd7d23ac9f4ebf005f88e44/ui/events/platform/x11/x11_event_source.cc
[modify] https://crrev.com/fd1cc4c7b4cb560f2fd7d23ac9f4ebf005f88e44/ui/events/platform/x11/x11_event_source.h

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a12f3aa9f4e8eefd3c8003106f54c4a2d2fef616

commit a12f3aa9f4e8eefd3c8003106f54c4a2d2fef616
Author: sky <sky@chromium.org>
Date: Tue Jun 28 16:29:38 2016

Fix bug in quicklaunch

RemoveWindow can be called when the messageloop is already
shutdown. If this happens we don't want to quit the messageloop as we
hit a DCHECK.

BUG= 594600 
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2103863002
Cr-Commit-Position: refs/heads/master@{#402486}

[modify] https://crrev.com/a12f3aa9f4e8eefd3c8003106f54c4a2d2fef616/mash/quick_launch/quick_launch_application.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8de9670ba51e7495887e666bfefa3728c1a37933

commit 8de9670ba51e7495887e666bfefa3728c1a37933
Author: sky <sky@chromium.org>
Date: Thu Jun 30 00:10:18 2016

Makes BitmapUploader handle null GLES2Context

Tests can hit this if mus is shutting down. Makes code early out,
assuming mus is in the process of shutting down.

BUG= 594600 
TEST=none
R=penghuang@chromium.org

Review-Url: https://codereview.chromium.org/2113533002
Cr-Commit-Position: refs/heads/master@{#403007}

[modify] https://crrev.com/8de9670ba51e7495887e666bfefa3728c1a37933/components/bitmap_uploader/bitmap_uploader.cc
[modify] https://crrev.com/8de9670ba51e7495887e666bfefa3728c1a37933/components/bitmap_uploader/bitmap_uploader.h

Project Member

Comment 22 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e53dead780ffb90958637c01b1792e53ff3f2081

commit e53dead780ffb90958637c01b1792e53ff3f2081
Author: sky <sky@chromium.org>
Date: Thu Jun 30 00:22:27 2016

Fixes crash in PanelLayoutManager

During shutdown of sysui I was occasionally crashing in
PanelLayoutManager as the window was null.

BUG= 594600 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2108383002
Cr-Commit-Position: refs/heads/master@{#403020}

[modify] https://crrev.com/e53dead780ffb90958637c01b1792e53ff3f2081/ash/common/wm/panels/panel_layout_manager.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb82553244fd22a01078f330ea8cefaa160e1901

commit eb82553244fd22a01078f330ea8cefaa160e1901
Author: sky <sky@chromium.org>
Date: Fri Jul 01 20:22:03 2016

Two fixes for mash browser_tests on chromes

If sysui crashes and restarts we can hit
RootWindowController::OnShelfWindowAvailable() more than once. The
code OnShelfWindowAvailable() calls to doesn't expect this and we
crash. I'm changing this code to do nothing in this case, which isn't
really right, but sysui is going away so this is all temporary.

The other change is to disable various services from being created in
chrome when in mash. These don't make sense for this config, so
disabling.

BUG= 594600 
TEST=covered by tests
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2114043002
Cr-Commit-Position: refs/heads/master@{#403512}

[modify] https://crrev.com/eb82553244fd22a01078f330ea8cefaa160e1901/ash/mus/root_window_controller.cc
[modify] https://crrev.com/eb82553244fd22a01078f330ea8cefaa160e1901/chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb82553244fd22a01078f330ea8cefaa160e1901

commit eb82553244fd22a01078f330ea8cefaa160e1901
Author: sky <sky@chromium.org>
Date: Fri Jul 01 20:22:03 2016

Two fixes for mash browser_tests on chromes

If sysui crashes and restarts we can hit
RootWindowController::OnShelfWindowAvailable() more than once. The
code OnShelfWindowAvailable() calls to doesn't expect this and we
crash. I'm changing this code to do nothing in this case, which isn't
really right, but sysui is going away so this is all temporary.

The other change is to disable various services from being created in
chrome when in mash. These don't make sense for this config, so
disabling.

BUG= 594600 
TEST=covered by tests
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2114043002
Cr-Commit-Position: refs/heads/master@{#403512}

[modify] https://crrev.com/eb82553244fd22a01078f330ea8cefaa160e1901/ash/mus/root_window_controller.cc
[modify] https://crrev.com/eb82553244fd22a01078f330ea8cefaa160e1901/chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Comment 25 by sky@chromium.org, Aug 29 2016

Status: Fixed (was: Started)
This now works, we need to run more than one test, but it's now live on the bots.
Labels: VerifyIn-55

Comment 27 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 28 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 29 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 30 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 31 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 33 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment