New issue
Advanced search Search tips

Issue 594594 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 595022
issue 607699

Blocking:
issue 604826
issue 604827



Sign in to add a comment

Implement min/max AudioParam attributes

Project Member Reported by rtoy@chromium.org, Mar 14 2016

Issue description

After deciding to specify nominal ranges for all of the AudioParam attributes, it was decided to put back the min/max attributes as readonly attributes specifying this nominal range.  See https://github.com/WebAudio/web-audio-api/pull/620 for the discussion and https://github.com/WebAudio/web-audio-api/pull/755 for the spec changes.


 

Comment 1 by rtoy@chromium.org, Mar 14 2016

Components: Blink>WebAudio

Comment 2 by rtoy@chromium.org, Mar 15 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)

Comment 3 by rtoy@chromium.org, Mar 16 2016

Blockedon: 595022
Need to solve  issue 595022  first since that affects whether there are limits for the reduction attribute.

Comment 4 by rtoy@chromium.org, Apr 27 2016

Blocking: 604827

Comment 5 by rtoy@chromium.org, Apr 27 2016

Blocking: 604826

Comment 6 by rtoy@chromium.org, Apr 28 2016

Blockedon: 607699
Project Member

Comment 7 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba

commit 71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba
Author: rtoy <rtoy@chromium.org>
Date: Mon May 16 18:03:05 2016

Add min/max values for AudioParams

Each AudioParam has a nominal range given by the min and max
attributes for the AudioParam.  Add these new attributes and set them
appropriately for each AudioParam.

Print a warning if the value is set (via the setter) outside the nominal range.

Spec: http://webaudio.github.io/web-audio-api/#AudioParam
WebAudio issue: https://github.com/WebAudio/web-audio-api/issues/673

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/CVOAEqoa2dc/OBPHcGFSBwAJ

BUG= 594594 
TEST=audioparam-nominal-range.html

Review-Url: https://codereview.chromium.org/1803153002
Cr-Commit-Position: refs/heads/master@{#393861}

[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[add] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range-expected.txt
[add] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range.html
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/LayoutTests/webaudio/biquad-automation-expected.txt
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/LayoutTests/webaudio/osc-custom-sweep-snr-expected.txt
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/LayoutTests/webaudio/osc-sawtooth-sweep-snr-expected.txt
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/LayoutTests/webaudio/osc-sine-sweep-snr-expected.txt
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/LayoutTests/webaudio/osc-square-sweep-snr-expected.txt
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/LayoutTests/webaudio/osc-triangle-sweep-snr-expected.txt
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/LayoutTests/webaudio/periodicwave-contexts-expected.txt
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/LayoutTests/webaudio/stereopannernode-panning-expected.txt
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/Source/modules/webaudio/AudioParam.h
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/Source/modules/webaudio/AudioParam.idl
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/Source/modules/webaudio/DelayNode.cpp
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp
[modify] https://crrev.com/71df40e1bab3e8d1bb48f539af9ae9cbb03f9bba/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp

Comment 8 by rtoy@chromium.org, May 18 2016

Labels: M-52
Status: Fixed (was: Started)

Sign in to add a comment