New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 594577 link

Starred by 3 users
Status: Fixed
Owner:
taku...@chromium.org
Closed: Nov 2016
Cc:
mfo...@chromium.org
█ apaci...@chromium.org
sko...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Display Cast toolbar icon ephemerally while local sessions are active

Project Member Reported by sko...@chromium.org, Mar 14 2016 
Per https://docs.google.com/document/d/1rNVAKEYKss7cpL-iulx7hFoxVEy2fH2gJ_Eqoeq9qAc/edit, there are cases where the lack of a toolbar icon for Cast / Media Router can put the user in a loss of control scenario.  We propose to display the Cast icon in the toolbar during while a local session is active, even if the user hasn't permanently added the icon to the toolbar.

Comment 1 by apaci...@chromium.org, Mar 14 2016

Cc: apaci...@chromium.org

Comment 2 by mfo...@chromium.org, Mar 23 2016

Labels: -Type-Bug -M-51 Type-Feature

Comment 3 by sko...@chromium.org, Mar 24 2016

Labels: M-52
Let's try to get this done in M52.

Comment 4 by sko...@chromium.org, Apr 22 2016

Labels: -M-52 M-53 OS-All

Comment 5 by mfo...@chromium.org, May 12 2016

Cc: mfo...@chromium.org

Comment 6 by mfo...@chromium.org, May 27 2016

Owner: ----
Status: Untriaged (was: Assigned)

Comment 7 by sko...@chromium.org, May 27 2016

Status: Available (was: Untriaged)

Comment 8 by taku...@chromium.org, Jun 29 2016

Owner: taku...@chromium.org
Status: Assigned (was: Available)

Comment 9 by taku...@chromium.org, Jul 1 2016

Cc: sko...@chromium.org
Status: Started (was: Assigned)
There are two ways to hide the action icon: one is to put it in the hotdog menu (what normal extension icons do when you click on "Hide in Chrome menu" in their context menu). The other is to just not show it anywhere. The former is better in terms of discoverability, but I'm not sure if we're allowed to do that. skonig@, what do you think?

Comment 10 by sko...@chromium.org, Jul 1 2016 

In the case where the user wants to remove the icon from their toolbar, I
think we have to completely remove it.  If the user chooses to pin the icon
to their toolbar, they can then later choose to move it to the
Hotdog/overflow if they want.
Project Member

Comment 11 by sheriffbot@chromium.org, Jul 15 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by taku...@chromium.org, Jul 18 2016 

I've implemented the ephemeral icon, as shown in the attached video. skonig@, please let me know if there are any changes you think I should make. If it looks good I'll be submitting this for code review.
ephemeral.ogv
1.6 MB View Download

Comment 13 by sko...@chromium.org, Jul 18 2016 

Takumi, this lgtm.  Thanks!
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de716ca8b6cffb4c7ae30990b3288b3499d28a4c

commit de716ca8b6cffb4c7ae30990b3288b3499d28a4c
Author: takumif <takumif@chromium.org>
Date: Tue Aug 16 17:47:22 2016

Show the Cast toolbar icon ephemerally when Cast is in use

This CL changes the behavior of the Cast/Media Router toolbar component
action icon. Currently, the only way to add the icon is by installing
the Cast extension from the Web Store. After this change, the icon will
be displayed temporarily whenever the Media Router dialog is open, or there
is an active local media route.

This CL also replaces the "Remove icon" option in the action context menu
with "Always show icon" which can be checked. When this option is unchecked,
the icon is neither on the toolbar nor in the overflow menu, and is only shown
ephemerally in the situations mentioned above.

We replace the word "popup" with "dialog" wherever possible in
MediaRouterAction, to stay consistent with the rest of Media Router files.

We also change the default position of the component actions on the toolbar
from the leftmost to the rightmost (same behavior as extension actions).

TBR=grt@chromium.org
BUG= 594577 

Review-Url: https://codereview.chromium.org/2155293002
Cr-Commit-Position: refs/heads/master@{#412280}

[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/app/media_router_strings.grdp
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/browser/extensions/component_migration_helper.cc
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/browser/extensions/component_migration_helper_unittest.cc
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/browser/ui/toolbar/media_router_action.cc
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/browser/ui/toolbar/media_router_action.h
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/browser/ui/toolbar/media_router_action_unittest.cc
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/browser/ui/toolbar/media_router_contextual_menu.h
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/browser/ui/toolbar/toolbar_actions_model.cc
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/browser/ui/toolbar/toolbar_actions_model.h
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.h
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/common/pref_names.cc
[modify] https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c/chrome/common/pref_names.h
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b3841e82bec9ffa674ba6596834ef4db2c95481

commit 3b3841e82bec9ffa674ba6596834ef4db2c95481
Author: takumif <takumif@chromium.org>
Date: Sat Aug 20 15:33:59 2016

Revert of Show the Cast toolbar icon ephemerally when Cast is in use (patchset #15 id:440001 of https://codereview.chromium.org/2155293002/ )

Reason for revert:
Reverting this CL since it is causing crashes and needs a redesign. Also reverting a related CL: https://codereview.chromium.org/2260873003/

Original issue's description:
> Show the Cast toolbar icon ephemerally when Cast is in use
>
> This CL changes the behavior of the Cast/Media Router toolbar component
> action icon. Currently, the only way to add the icon is by installing
> the Cast extension from the Web Store. After this change, the icon will
> be displayed temporarily whenever the Media Router dialog is open, or there
> is an active local media route.
>
> This CL also replaces the "Remove icon" option in the action context menu
> with "Always show icon" which can be checked. When this option is unchecked,
> the icon is neither on the toolbar nor in the overflow menu, and is only shown
> ephemerally in the situations mentioned above.
>
> We replace the word "popup" with "dialog" wherever possible in
> MediaRouterAction, to stay consistent with the rest of Media Router files.
>
> We also change the default position of the component actions on the toolbar
> from the leftmost to the rightmost (same behavior as extension actions).
>
> TBR=grt@chromium.org
> BUG= 594577 
>
> Committed: https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c
> Cr-Commit-Position: refs/heads/master@{#412280}

TBR=anthonyvd@chromium.org,apacible@chromium.org,msw@chromium.org,rdevlin.cronin@chromium.org,mfoltz@chromium.org,grt@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 594577 

Review-Url: https://codereview.chromium.org/2260343002
Cr-Commit-Position: refs/heads/master@{#413338}

[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/app/media_router_strings.grdp
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/browser/extensions/component_migration_helper.cc
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/browser/extensions/component_migration_helper_unittest.cc
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/browser/ui/toolbar/media_router_action.cc
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/browser/ui/toolbar/media_router_action.h
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/browser/ui/toolbar/media_router_action_unittest.cc
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/browser/ui/toolbar/media_router_contextual_menu.h
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/browser/ui/toolbar/toolbar_actions_model.cc
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/browser/ui/toolbar/toolbar_actions_model.h
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.h
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/common/pref_names.cc
[modify] https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481/chrome/common/pref_names.h

Comment 16 by sko...@chromium.org, Sep 9 2016

Labels: -M-54 M-55
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be86872a218127fdf92001a1f69e044239a058b4

commit be86872a218127fdf92001a1f69e044239a058b4
Author: takumif <takumif@chromium.org>
Date: Mon Sep 19 21:54:13 2016

Create MediaRouterActionController and MediaRouterUIService

This CL is part 1 of 3 CLs to implement ephemeral toolbar icon for media router:

1. Implement MediaRouterActionController (this CL)
2. Show ephemeral icon for active local routes and issues [1]
3. Show ephemeral icon for open dialog

The icon will be shown when the "always show icon" setting is on, or there is a local media route, an unresolved issue, or an open dialog. The MediaRouterActionController will be responsible for telling the ToolbarActionsModel to show/hide the MR icon.

MediaRouterUIService is a KeyedService (a per-profile instance) that owns MediaRouterActionController.

These CLs are a redesign of a previous CL [2], which has been reverted for its bugs.

[1] https://codereview.chromium.org/2332693003/
[2] https://codereview.chromium.org/2155293002/

BUG= 594577 

Review-Url: https://codereview.chromium.org/2294973002
Cr-Commit-Position: refs/heads/master@{#419581}

[modify] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/extensions/component_migration_helper.cc
[modify] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/extensions/component_migration_helper.h
[modify] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/media/router/media_router_factory.cc
[modify] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/media/router/media_router_factory.h
[modify] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/media/router/media_router_factory_unittest.cc
[add] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/media/router/media_router_ui_service.cc
[add] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/media/router/media_router_ui_service.h
[add] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/media/router/media_router_ui_service_factory.cc
[add] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/media/router/media_router_ui_service_factory.h
[add] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/media/router/media_router_ui_service_factory_unittest.cc
[modify] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/ui/toolbar/media_router_action_controller.cc
[add] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/ui/toolbar/media_router_action_controller.h
[add] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc
[modify] https://crrev.com/be86872a218127fdf92001a1f69e044239a058b4/chrome/test/BUILD.gn
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b22235a16193be6cfa6e199a5c7a2427a7b505e6

commit b22235a16193be6cfa6e199a5c7a2427a7b505e6
Author: takumif <takumif@chromium.org>
Date: Thu Sep 22 00:44:44 2016

Show media router toolbar icon ephemerally for active local routes and issues

This CL is part 2 of 3 CLs to implement ephemeral toolbar icon for media router:

1. Implement MediaRouterActionController [1]
2. Show ephemeral icon for active local routes and issues (this CL)
3. Show ephemeral icon for open dialog

These CLs are a redesign of a previous CL [2], which has been reverted for its bugs. Since the contents of this CL are similar to those of [2], the first patch in this CL is from [2] for comparison.

This CL makes the media router toolbar icon show temporarily whenever there is an active local media route or an issue.

This CL also replaces the "Remove icon" option in the action context menu with "Always show icon" which can be checked. When this option is unchecked, the icon is neither on the toolbar nor in the overflow menu, and is only shown ephemerally in the situations mentioned above.

We replace the word "popup" with "dialog" wherever possible in MediaRouterAction, to stay consistent with the rest of Media Router files.

We also change the default position of the component actions on the toolbar from the leftmost to the rightmost (same behavior as extension actions).

Major differences between the original CL [2] and this CL is that now the MediaRouterAction is no longer responsible for determining whether it should stay shown or be hidden. Instead, showing/hiding of the icon is done by the MediaRouterActionController. Also the unit tests for the ephemeral icon has been moved to the unit tests for MediaRouterActionController (in [1]). MediaRouterDialogController-related changes will be in part 3.

[1] https://codereview.chromium.org/2294973002/
[2] https://codereview.chromium.org/2155293002/

BUG= 594577 

Review-Url: https://codereview.chromium.org/2332693003
Cr-Commit-Position: refs/heads/master@{#420217}

[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/app/media_router_strings.grdp
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/media/router/media_router_ui_service.cc
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/media/router/media_router_ui_service.h
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/media/router/media_router_ui_service_factory.cc
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/media/router/media_router_ui_service_factory.h
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/media/router/media_router_ui_service_factory_unittest.cc
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/ui/toolbar/media_router_action.cc
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/ui/toolbar/media_router_action.h
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/ui/toolbar/media_router_action_unittest.cc
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/ui/toolbar/media_router_contextual_menu.h
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/ui/toolbar/toolbar_actions_model.cc
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/ui/toolbar/toolbar_actions_model.h
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
[modify] https://crrev.com/b22235a16193be6cfa6e199a5c7a2427a7b505e6/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc

Comment 19 by sko...@chromium.org, Oct 5 2016

Labels: -M-55 M-56
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe

commit 89fc2a78d69cb432b445da453fd3f6fd02d4ebfe
Author: takumif <takumif@chromium.org>
Date: Thu Nov 10 18:28:39 2016

Show Media Router toolbar icon ephemerally for MR dialogs

This CL is part 3 of 3 CLs to implement ephemeral toolbar icon for media router:

1. Implement MediaRouterActionController [1]
2. Show ephemeral icon for active local routes and issues [2]
3. Show ephemeral icon for open dialog (this CL)

This CL makes MRDialogControllerImpl notify MRActionController whenever a dialog is shown or hidden, and MRActionController may show or hide the toolbar action icon depending on that. The icon will be shown when there are open dialogs, local routes or issues, or when the "Always Show Icon" option is checked.

In MRUIBrowserTest, this CL replaces MRAction manually instantiated during setup with one whose instantiation is initiated by MRActionController.

[1] https://codereview.chromium.org/2294973002
[2] https://codereview.chromium.org/2332693003

BUG= 594577 

Review-Url: https://codereview.chromium.org/2410553002
Cr-Commit-Position: refs/heads/master@{#431296}

[modify] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/media/router/media_router_dialog_controller_unittest.cc
[modify] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/media/router/media_router_ui_service.cc
[modify] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/media/router/media_router_ui_service.h
[modify] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/media/router/media_router_ui_service_factory_unittest.cc
[modify] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/ui/toolbar/media_router_action_controller.cc
[modify] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/ui/toolbar/media_router_action_controller.h
[modify] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc
[modify] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/ui/toolbar/media_router_action_unittest.cc
[add] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/ui/toolbar/mock_media_router_action_controller.cc
[add] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/ui/toolbar/mock_media_router_action_controller.h
[modify] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
[modify] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc
[modify] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.h
[modify] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
[delete] https://crrev.com/116138bad2403c5f51580005842f226beab0bf2e/chrome/browser/ui/webui/media_router/media_router_test.cc
[delete] https://crrev.com/116138bad2403c5f51580005842f226beab0bf2e/chrome/browser/ui/webui/media_router/media_router_test.h
[add] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/ui/webui/media_router/media_router_web_ui_test.cc
[add] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/ui/webui/media_router/media_router_web_ui_test.h
[modify] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
[modify] https://crrev.com/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe/chrome/test/BUILD.gn

Comment 21 by taku...@chromium.org, Nov 15 2016

Status: Fixed (was: Started)
►

Sign in to add a comment