New issue
Advanced search Search tips

Issue 594576 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Mar 2016
Cc:
agrieve@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Android GN+clang does not use chromium clang plugins

Project Member Reported by boliu@chromium.org, Mar 14 2016 
I tried these already:

is_clang = true
clang_use_chrome_plugins = true

Doesn't seem to be generating this warning, or that the warning was ignored (?):

./../android_webview/browser/shared_renderer_state.h:37:3: error: [chromium-style] Complex class/struct needs an explicit out-of-line destructor.

Haven't looked into it too much yet..

Comment 1 by boliu@chromium.org, Mar 14 2016 

Oh, seems in build/config/clang/BUILD.gn, just need to expand the "is_linux" block to "is_linux || is_android". Patch coming up
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1131c627f1a8489711b173f683e3c3d43542fe2b

commit 1131c627f1a8489711b173f683e3c3d43542fe2b
Author: boliu <boliu@chromium.org>
Date: Mon Mar 14 19:23:49 2016

Android: use chromium clang plugins in gn build

BUG= 594576 

Review URL: https://codereview.chromium.org/1787423007

Cr-Commit-Position: refs/heads/master@{#381038}

[modify] https://crrev.com/1131c627f1a8489711b173f683e3c3d43542fe2b/build/config/clang/BUILD.gn

Comment 3 by boliu@chromium.org, Mar 14 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment