CTS WebChromeClientTest#testOnJsBeforeUnload failing |
||
Issue descriptionFirst failure here: https://build.chromium.org/p/chromium.android/builders/Android%20WebView%20CTS%20L-MR1%20%28dbg%29/builds/8321 Blamelist is r36453-r36474. I suspect this is an intentional breakage from this change: https://codereview.chromium.org/1714573002. Need to confirm that. And if this is the intentional change, then I guess another case where we need to fix the test (or remove it altogether). cc torne too since it's more like a policy decision
,
Mar 16 2016
This bug is similar to crbug/520765 In this case, however, I think the right behavior is to change the cts test, in other words remove it. my reasons: the impact change would be a UI change and this should not break the apps in a way that they will not be operable anymore, and this test does not seem like should be a CTS test first of all, because according to the comment #1 in crbug above, the spec leaves it to the user agent to decide how to interpret the string. if everybody agrees, let's open an internal bug, let our cts folks know about it, and give waivers for this test.
,
Mar 17 2016
ok. In the mean time, I will also disable this test to make CTS bot green again.
,
Mar 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/dc13a76882327477c1c599a4aee7ffb80e6d4192 commit dc13a76882327477c1c599a4aee7ffb80e6d4192 Author: hush@chromium.org <hush@chromium.org> Date: Fri Mar 18 21:18:31 2016 Disable WebView CTS WebChromeClientTest#testOnJsBeforeUnload This CTS test used a blink feature to customize the unload message. This feature has been removed by blink. As a result, this test will fail permanently. We plan to remove this CTS test from future CTS publishes. BUG= 594573 Review URL: https://codereview.chromium.org/1815033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299391 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/dc13a76882327477c1c599a4aee7ffb80e6d4192/scripts/slave/recipe_modules/chromium_android/api.py
,
Mar 18 2016
Filed b/27745434 internally to remove the cts. Nothing more to do in upstream here. Closing |
||
►
Sign in to add a comment |
||
Comment 1 by boliu@chromium.org
, Mar 14 2016