New issue
Advanced search Search tips

Issue 594563 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Logspam on 32 bit devices due to missing 64 bit blobs

Project Member Reported by tobiasjs@chromium.org, Mar 14 2016

Issue description

e.g.

03-14 15:20:22.275  9384  9384 E ApkAssets: Error while loading asset assets/natives_blob_64.bin: java.io.FileNotFoundException: assets/natives_blob_64.bin
03-14 15:20:22.276  9384  9384 E ApkAssets: Error while loading asset assets/snapshot_blob_64.bin: java.io.FileNotFoundException: assets/snapshot_blob_64.bin

Should be avoided if possible.

 
The error should be logged (and be fatal) when we go to use the blob, rather than when we prepare it.
Cc: rmcilroy@chromium.org torne@chromium.org tobiasjs@chromium.org
 Issue 604670  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02b5769f94789389b278bb7a6157ce6fd94b5dcd

commit 02b5769f94789389b278bb7a6157ce6fd94b5dcd
Author: tobiasjs <tobiasjs@chromium.org>
Date: Tue Apr 26 16:14:37 2016

Suppress logspam arising from trying to register/load v8 blobs.

Because we don't know which blobs we will end up using, because
we can't predict from the browser process what ABI the renderer
process will end up executing with, we can't log an error
immediately. Instead we should pass through the returned invalid
file descriptor and let the renderer process fail if it doesn't
have access to the blobs it needs.

BUG= 594563 

Review URL: https://codereview.chromium.org/1921573002

Cr-Commit-Position: refs/heads/master@{#389799}

[modify] https://crrev.com/02b5769f94789389b278bb7a6157ce6fd94b5dcd/base/android/java/src/org/chromium/base/ApkAssets.java

Status: Fixed (was: Assigned)

Sign in to add a comment