SyncTest#testStopAndStartSyncThroughAndroid intermittently fails on Android Test dbg |
||||||
Issue descriptionThis test intermittently fails on AndroidTest(dbg). The timeout (20 sec) already seems reasonably long, and I'm not convinced that increasing it would help so I've marked it flaky for the moment. This test started failing around build 33369 (spun on March 12) with no obvious connected CLs. See https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29 Sample log: ******************************************************************************** C 238.521s Main [FAIL] org.chromium.chrome.browser.sync.SyncTest#testStopAndStartSyncThroughAndroid: C 238.521s Main junit.framework.AssertionFailedError: Timed out waiting for sync cycle to complete. C 238.521s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollForCriteria(CriteriaHelper.java:69) C 238.521s Main at org.chromium.chrome.test.util.browser.sync.SyncTestUtil.triggerSyncAndWaitForCompletion(SyncTestUtil.java:74) C 238.521s Main at org.chromium.chrome.test.util.browser.sync.SyncTestUtil.verifySyncIsActiveForAccount(SyncTestUtil.java:111) C 238.522s Main at org.chromium.chrome.browser.sync.SyncTest.testStopAndStartSyncThroughAndroid(SyncTest.java:145) C 238.522s Main at java.lang.reflect.Method.invokeNative(Native Method) C 238.522s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 238.522s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 238.522s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 238.522s Main at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:793) C 238.522s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) C 238.522s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) C 238.522s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 238.522s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 238.522s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) C 238.522s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701) ********************************************************************************
,
Mar 14 2016
,
Oct 6 2016
,
Oct 6 2016
,
Oct 6 2016
,
Oct 12 2016
,
Jan 19 2017
Closing the flaky bugs assigned to me as WontFix as I am leaving Chrome. If these are still occurring please go through the sync triage process again.
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6827686a55d3ac193c5ea456053f6036405e52ce commit 6827686a55d3ac193c5ea456053f6036405e52ce Author: Marc Treib <treib@chromium.org> Date: Mon Jan 14 11:01:12 2019 Improve Java SyncTests around starting/stopping and Android sync settings Currently, the interaction between Android's "Chrome sync" setting (mapping to DISABLE_REASON_USER_CHOICE) and "Master sync" setting (mapping to DISABLE_REASON_PLATFORM_OVERRIDE) is quite subtle and fragile. I'm hoping to simplify this by making the two settings completely orthogonal. As a first step, this CL improves the test coverage, and adds some TODOs. While we're here, also remove a FlakyTest annotation, since the test doesn't seem to be flaky anymore. Bug: 921025, 594558 Change-Id: Idd00cdcb35c3bee1102da7071fc1394c91162ceb Reviewed-on: https://chromium-review.googlesource.com/c/1406970 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#622415} [modify] https://crrev.com/6827686a55d3ac193c5ea456053f6036405e52ce/chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java [modify] https://crrev.com/6827686a55d3ac193c5ea456053f6036405e52ce/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java [modify] https://crrev.com/6827686a55d3ac193c5ea456053f6036405e52ce/chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java [modify] https://crrev.com/6827686a55d3ac193c5ea456053f6036405e52ce/chrome/browser/sync/profile_sync_service_android.cc [modify] https://crrev.com/6827686a55d3ac193c5ea456053f6036405e52ce/chrome/browser/sync/profile_sync_service_android.h [modify] https://crrev.com/6827686a55d3ac193c5ea456053f6036405e52ce/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/sync/SyncTestUtil.java |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Mar 14 2016