New issue
Advanced search Search tips

Issue 594551 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Experiment: compile eagerly for code cache.

Project Member Reported by yangguo@chromium.org, Mar 14 2016

Issue description

Feature description: compile inner functions eagerly when the result is targeted for the code cache

Eng owner: yangguo@chromium.org, vogelheim@chromium.org
Product owner: jochen@chromium.org

Design doc: https://docs.google.com/document/d/1Nuf_5u4Qzpqc9sU8FtPkgO7873h1vOUeVJnjkPmZXkQ/edit

This is just an experiment. A launch is optional at this point. Existing UMA counters should already help with evaluating.

 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2a197f04ebac1ec78ecd1598c0a94c2d49bf64c

commit d2a197f04ebac1ec78ecd1598c0a94c2d49bf64c
Author: vogelheim <vogelheim@chromium.org>
Date: Thu Apr 07 14:06:22 2016

Add features (feature flags) for V8 serialization experiments.

The intent is to evaluate these w/ Finch, starting with M51.

Context on those two features: crbug.com/594551, crrev.com/1804433004

BUG=chromium:594551

Review URL: https://codereview.chromium.org/1864063002

Cr-Commit-Position: refs/heads/master@{#385746}

[modify] https://crrev.com/d2a197f04ebac1ec78ecd1598c0a94c2d49bf64c/chrome/renderer/chrome_render_process_observer.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e10d2ca83e75f3381970df6f570001e6ce2d8022

commit e10d2ca83e75f3381970df6f570001e6ce2d8022
Author: vogelheim <vogelheim@chromium.org>
Date: Fri Apr 08 10:05:30 2016

Add fieldtrial config for V8 serialize options.

V8 would like to gather real world performance data for two new serialization
options. It was recommended to:

    1. Pick one of two options for test, whichever you like better (more likely to advance).
    2. Make sure to change test config (fieldtrial_testing_config_*.json) if your belief changes.

I've picked "Serialize eager + pre-age code", since 1, this is the more
aggressive proposal and 2, it increases the code coverage. (This option
enables the code path for the other proposal + some additions.)

This adds the field trial for all platforms except iOS, since iOS Chromium
does not use V8.

BUG=chromium:594551

Review URL: https://codereview.chromium.org/1866323002

Cr-Commit-Position: refs/heads/master@{#386033}

[modify] https://crrev.com/e10d2ca83e75f3381970df6f570001e6ce2d8022/testing/variations/fieldtrial_testing_config_android.json
[modify] https://crrev.com/e10d2ca83e75f3381970df6f570001e6ce2d8022/testing/variations/fieldtrial_testing_config_chromeos.json
[modify] https://crrev.com/e10d2ca83e75f3381970df6f570001e6ce2d8022/testing/variations/fieldtrial_testing_config_linux.json
[modify] https://crrev.com/e10d2ca83e75f3381970df6f570001e6ce2d8022/testing/variations/fieldtrial_testing_config_mac.json
[modify] https://crrev.com/e10d2ca83e75f3381970df6f570001e6ce2d8022/testing/variations/fieldtrial_testing_config_win.json

vogelheim@: is there any progress on this? Is the field trial already running?
I would like to know what is the expected optimization when "Serialize eager + pre-age code" is enabled? I see enabling these flags generate more v8 compiled code cache in the disk. I suppose it should improve pageload time from 3rd pageload onwards as it produces compiled code cache on 2nd pageload. Is there any measurement data?
Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment