New issue
Advanced search Search tips

Issue 594539 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 582920



Sign in to add a comment

Refactor RTCPeerConnection certificate generation to use WebPassOwnPtr

Project Member Reported by guidou@chromium.org, Mar 14 2016

Issue description

We should avoid doing "delete this" and using naked pointers to pass ownership.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2c575c70ec89a8b60cf8f30ec7d8370b5a903ca

commit e2c575c70ec89a8b60cf8f30ec7d8370b5a903ca
Author: guidou <guidou@chromium.org>
Date: Mon Mar 14 16:12:59 2016

Refactor WebRTC certificate generation to use WebPassOwnPtr.

BUG= 594539 

Review URL: https://codereview.chromium.org/1804563002

Cr-Commit-Position: refs/heads/master@{#380984}

[modify] https://crrev.com/e2c575c70ec89a8b60cf8f30ec7d8370b5a903ca/content/renderer/media/rtc_certificate.cc
[modify] https://crrev.com/e2c575c70ec89a8b60cf8f30ec7d8370b5a903ca/content/renderer/media/rtc_certificate.h
[modify] https://crrev.com/e2c575c70ec89a8b60cf8f30ec7d8370b5a903ca/content/renderer/media/rtc_certificate_generator.cc
[modify] https://crrev.com/e2c575c70ec89a8b60cf8f30ec7d8370b5a903ca/content/renderer/media/rtc_certificate_generator.h
[modify] https://crrev.com/e2c575c70ec89a8b60cf8f30ec7d8370b5a903ca/third_party/WebKit/Source/modules/mediastream/RTCCertificate.cpp
[modify] https://crrev.com/e2c575c70ec89a8b60cf8f30ec7d8370b5a903ca/third_party/WebKit/Source/modules/mediastream/RTCCertificate.h
[modify] https://crrev.com/e2c575c70ec89a8b60cf8f30ec7d8370b5a903ca/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp
[modify] https://crrev.com/e2c575c70ec89a8b60cf8f30ec7d8370b5a903ca/third_party/WebKit/Source/platform/mediastream/RTCConfiguration.h
[modify] https://crrev.com/e2c575c70ec89a8b60cf8f30ec7d8370b5a903ca/third_party/WebKit/public/platform/WebRTCCertificate.h
[modify] https://crrev.com/e2c575c70ec89a8b60cf8f30ec7d8370b5a903ca/third_party/WebKit/public/platform/WebRTCCertificateGenerator.h

Comment 2 by guidou@chromium.org, Mar 18 2016

Status: Fixed (was: Started)

Sign in to add a comment