googNoiseSuppression constraint not working
Reported by
asherco...@audyx.com,
Mar 14 2016
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.26 Safari/537.36 Example URL: https://jsfiddle.net/jerLcudn/8/ Steps to reproduce the problem: 1. Open the provided url 2. Open the developer console 3. Click on the "start" button What is the expected behavior? A list of the existing audio input devices should be printed in the console What went wrong? An error occurs: NavigatorUserMediaError {name: "TrackStartError", message: "", constraintName: ""} Did this work before? Yes Chrome 49.0.2623.87 Is it a problem with Flash or HTML5? HTML5 Does this work in other browsers? Yes Chrome version: 50.0.2661.26 Channel: beta OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 21.0 r0
,
Mar 15 2016
,
Mar 15 2016
Found it. Will fix.
,
Mar 15 2016
Per chat, Harald's one-character fix is out for review, and assuming it passes a quick canary sanity check, it will need to be merged into M50.
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a5bdb2a2d9f14ef06dcbccaf36bcdbb38868d81 commit 0a5bdb2a2d9f14ef06dcbccaf36bcdbb38868d81 Author: hta <hta@chromium.org> Date: Tue Mar 15 18:49:38 2016 Fix a spelling mistake in a constraint name This error prevented the "googNoiseSuppression" constraint from being applied properly. Tested manually. BUG= 594523 Review URL: https://codereview.chromium.org/1800163002 Cr-Commit-Position: refs/heads/master@{#381269} [modify] https://crrev.com/0a5bdb2a2d9f14ef06dcbccaf36bcdbb38868d81/third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp
,
Mar 16 2016
Verified that today's Canary 51.0.2680.0 has the fix, and the fix looks good! - On click of 'Start' in the page https://jsfiddle.net/jerLcudn/8/, the existing audio input devices are listed in the JS console (attached screenshot) - The spelling error in the constraint name has been corrected; as seen in chrome://webrtc-internals https://screenshot.googleplex.com/tejaDQYAPOW.png Requesting a merge of https://codereview.chromium.org/1800163002 into M50. I've verified that the fix works as expected in Canary build 51.0.2680.0.
,
Mar 16 2016
,
Mar 16 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 16 2016
Please try to merge your change to M50 branch 2661 some time this week in order to make it to next week Beta release. Thank you.
,
Mar 19 2016
,
Mar 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7435e6699798f7c86dd5bd4a3451b0302cce26f1 commit 7435e6699798f7c86dd5bd4a3451b0302cce26f1 Author: Harald Alvestrand <hta@chromium.org> Date: Mon Mar 21 07:47:16 2016 Fix a spelling mistake in a constraint name This error prevented the "googNoiseSuppression" constraint from being applied properly. Tested manually. BUG= 594523 Review URL: https://codereview.chromium.org/1800163002 Cr-Commit-Position: refs/heads/master@{#381269} (cherry picked from commit 0a5bdb2a2d9f14ef06dcbccaf36bcdbb38868d81) Review URL: https://codereview.chromium.org/1818913002 . Cr-Commit-Position: refs/branch-heads/2661@{#305} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/7435e6699798f7c86dd5bd4a3451b0302cce26f1/third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp
,
Mar 23 2016
Verified in M50 Beta 50.0.2661.49 - On click of 'Start' in the page https://jsfiddle.net/jerLcudn/8/, the existing audio input devices are listed in the JS console - The spelling error in the constraint name has been corrected; as seen in chrome://webrtc-internals |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by yini...@chromium.org
, Mar 14 2016