New issue
Advanced search Search tips

Issue 594519 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Remove support for old version of Xcode (pre 6.0) from iossim

Project Member Reported by sdefresne@chromium.org, Mar 14 2016

Issue description

// TODO(lliabraa): Once all builders are on Xcode 6 this ifdef can be removed
// ( crbug.com/385030 ).

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3825f0fad8cd30b8c0748101620d74ac512d4bb6

commit 3825f0fad8cd30b8c0748101620d74ac512d4bb6
Author: sdefresne <sdefresne@chromium.org>
Date: Wed Mar 16 10:50:10 2016

Remove support for old version of Xcode from iossim.

All bots and developers are now using Xcode 7.0 or more recent to build
iOS so remove support for version of Xcode older than 6.0 from iossim.

TBR=rohitrao@chromium.org
BUG= 594519 

Review URL: https://codereview.chromium.org/1796093003

Cr-Commit-Position: refs/heads/master@{#381428}

[modify] https://crrev.com/3825f0fad8cd30b8c0748101620d74ac512d4bb6/testing/iossim/iossim.gyp
[modify] https://crrev.com/3825f0fad8cd30b8c0748101620d74ac512d4bb6/testing/iossim/iossim.mm

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2461a73bb77217ef3bbb35a3f32ab5e73eae640b

commit 2461a73bb77217ef3bbb35a3f32ab5e73eae640b
Author: sdefresne <sdefresne@chromium.org>
Date: Thu Mar 17 10:25:44 2016

Add config to enable ARC on iOS/OS X to //build/config.

Add a new config //build/config/compiler:enable_arc that adds the
required flag to enable ARC (automatic reference counting).

BUG= 594519 

Review URL: https://codereview.chromium.org/1806513002

Cr-Commit-Position: refs/heads/master@{#381686}

[modify] https://crrev.com/2461a73bb77217ef3bbb35a3f32ab5e73eae640b/build/config/compiler/BUILD.gn
[modify] https://crrev.com/2461a73bb77217ef3bbb35a3f32ab5e73eae640b/ios/third_party/gcdwebserver/BUILD.gn
[modify] https://crrev.com/2461a73bb77217ef3bbb35a3f32ab5e73eae640b/ios/third_party/ochamcrest/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b121e47561bb4dd582adff12146655645368639

commit 6b121e47561bb4dd582adff12146655645368639
Author: sdefresne <sdefresne@chromium.org>
Date: Thu Mar 17 10:45:45 2016

Add BUILD.gn rules to compile third_party/class-dump.

Add third_party/class-dump/BUILD.gn to build class-dump as a host tool as
part of the iOS build.

Create a template "class_dump" (in third_party/class-dump/class-dump.gni)
to simplify the execution of the class-dump tool on given framework. This
required converting testing/iossim/redirect-stdout.sh to a python script
as gn can only invokes python script.

TBR=rohitrao@chromium.org
BUG= 594519 

Review URL: https://codereview.chromium.org/1806523002

Cr-Commit-Position: refs/heads/master@{#381687}

[modify] https://crrev.com/6b121e47561bb4dd582adff12146655645368639/testing/iossim/iossim.gyp
[delete] https://crrev.com/2461a73bb77217ef3bbb35a3f32ab5e73eae640b/testing/iossim/redirect-stdout.sh
[add] https://crrev.com/6b121e47561bb4dd582adff12146655645368639/third_party/class-dump/BUILD.gn
[add] https://crrev.com/6b121e47561bb4dd582adff12146655645368639/third_party/class-dump/class-dump.gni
[modify] https://crrev.com/6b121e47561bb4dd582adff12146655645368639/third_party/class-dump/class-dump.gyp
[add] https://crrev.com/6b121e47561bb4dd582adff12146655645368639/third_party/class-dump/class-dump.py

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eebcd9484c2ef7eb4ad8199734f8d98a8e3c07d6

commit eebcd9484c2ef7eb4ad8199734f8d98a8e3c07d6
Author: sdefresne <sdefresne@chromium.org>
Date: Thu Mar 17 10:56:41 2016

Add testing/iossim/BUILD.gn to build iossim as host for iOS build.

Remove some dead const variables flagged as such by clang (instead
of deactivating the compiler warning as the change was simple).

TBR=rohitrao@chromium.org
BUG= 594519 

Review URL: https://codereview.chromium.org/1797253002

Cr-Commit-Position: refs/heads/master@{#381690}

[add] https://crrev.com/eebcd9484c2ef7eb4ad8199734f8d98a8e3c07d6/testing/iossim/BUILD.gn
[modify] https://crrev.com/eebcd9484c2ef7eb4ad8199734f8d98a8e3c07d6/testing/iossim/iossim.gyp

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d689ca9b2db1f4a5629c50e5fc2f97e47795197

commit 8d689ca9b2db1f4a5629c50e5fc2f97e47795197
Author: sdefresne <sdefresne@chromium.org>
Date: Thu Mar 17 13:05:02 2016

Add iossim as data_deps for iOS application bundles.

When targetting simulator, builds iossim as a data_deps for all iOS
application bundle as it is required to run the bundle on simulator
from the command-line.

BUG= 594519 

Review URL: https://codereview.chromium.org/1800083003

Cr-Commit-Position: refs/heads/master@{#381696}

[modify] https://crrev.com/8d689ca9b2db1f4a5629c50e5fc2f97e47795197/build/config/ios/rules.gni

Sign in to add a comment