New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 594509 link

Starred by 4 users
Status: Fixed
Owner:
cwallez@chromium.org
Closed: Mar 2016
Cc:
cwallez@chromium.org
nyerramilli@chromium.org
█ rnimmagadda@chromium.org
█ ranjitkan@chromium.org
zmo@chromium.org
jmad...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Webgl Vertex Problem

Reported by p...@sketchfab.com, Mar 14 2016 
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36

Example URL:
https://sketchfab.com/models/205cd8cc2e5949f7be3e49ebaa9e034d

Steps to reproduce the problem:
1. go to https://sketchfab.com/models/205cd8cc2e5949f7be3e49ebaa9e034d And wait for page completely loaded with 3D model loaded
2. compare with same url/model on stable
3. constate the broken mesh on canary

What is the expected behavior?
correct mesh rendering

What went wrong?
wrong mesh rendering

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? Yes Works on stable Chrome : 49.0.2623.87 m

Does this work in other browsers? Yes 

Chrome version:  51.0.2677.0  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 21.0 r0

Comment 1 by rnimmagadda@chromium.org, Mar 16 2016

Cc: zmo@chromium.org rnimmagadda@chromium.org
Components: Blink>WebGL
Labels: -Type-Compat M-51 Type-Bug-Regression
Owner: jmad...@chromium.org
Status: Assigned (was: Unconfirmed)
====================================

Good Build:

51.0.2673.0    Base Position: 380313


Bad Build:

51.0.2674.0    Base Position: 380495

=====================================

Able to repro this issue only on Windows [tested on Windows 7 & 10] for the Google Chrome Canary Version - 51.0.2679.0

This is a regression issue broken in M51, below mentioned is the bisect info:

CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/4d3257d1689fef1fb495e1cdf025611605ee310b..f27bf8991392753e2a53d9869bffaeb827b5a4eb

https://chromium.googlesource.com/angle/angle.git/+log/b5abec3..bd38271

Suspecting Commit: 7d8585b802b7eb741b380bd0d05769281d9507c9		

Review URL: https://chromium-review.googlesource.com/330173

@jmadill: Could you please look into the issue, and if it has nothing to do with your changes and if possible please do assign it to the concerned owner.

Note: Issue not observed on MAC (10.11.3) & Linux OS [Ubuntu Trusty (14.04)].

Thank you.
594509.png
709 KB View Download

Comment 2 by jmad...@chromium.org, Mar 16 2016

Cc: jmad...@chromium.org
Owner: cwallez@chromium.org
Won't be able to triage this since I'm out-of-office. Corentin can you figure this out and revert any of my patches if necessary? Or quickly hand it off to someone else if you cannot?

Comment 3 by cwallez@chromium.org, Mar 16 2016 

Thanks for narrowing down the regression range. 7d8585b802b7eb741b380bd0d05769281d9507c9 is indeed the commit causing the issue, I have a revert in the CQ now.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/00f394ec669faa3a778180991204caa474eb1dd2

commit 00f394ec669faa3a778180991204caa474eb1dd2
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Mar 16 19:09:11 2016

Revert Dirty bits for VertexArray11

This is a combination of two reverts:
Revert "D3D11: Remove unused mRenderer from VertexArray11."
Revert "D3D11: Implement dirty bits for VertexArray11."
Reverting only the first commit would trigger warnings on the Windows
clang bot.

BUG= 594509 
BUG= angleproject:1327 

This reverts commit fc4712b5ed270436f2993bfda9e916d4f92684a4.
This reverts commit 7d8585b802b7eb741b380bd0d05769281d9507c9.

Change-Id: I612dbba0816d6144f71ce815701c13a798585bc7
Reviewed-on: https://chromium-review.googlesource.com/332989
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/tests/gl_tests/VertexAttributeTest.cpp
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/VertexArray.h
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libGLESv2.gypi
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/d3d11/Buffer11.cpp
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/d3d11/Buffer11.h
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/d3d11/Renderer11.cpp
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/tests/gl_tests/BufferDataTest.cpp
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/d3d11/InputLayoutCache.cpp
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/d3d11/RenderTarget11.h
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/d3d11/StateManager11.h
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/d3d11/StateManager11.cpp
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/BufferD3D.cpp
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/BufferD3D.h
[delete] https://crrev.com/a0fc18d9f7c921a1c62927b2548a29e1ff1807f0/src/libANGLE/renderer/d3d/d3d11/VertexArray11.cpp
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/VertexArray.cpp
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/VertexDataManager.cpp
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/RendererD3D.cpp
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/RendererD3D.h
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/VertexDataManager.h
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/d3d9/Renderer9.h
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/d3d9/Renderer9.cpp
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/VertexBuffer.h
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/d3d11/RenderTarget11.cpp
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/d3d11/renderer11_utils.cpp
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/d3d11/InputLayoutCache.h
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/d3d11/renderer11_utils.h
[modify] https://crrev.com/00f394ec669faa3a778180991204caa474eb1dd2/src/libANGLE/renderer/d3d/d3d11/VertexArray11.h
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c91724efe5e917f992a85bdf358602ac1046cddf

commit c91724efe5e917f992a85bdf358602ac1046cddf
Author: cwallez <cwallez@google.com>
Date: Fri Mar 18 15:48:55 2016

Roll ANGLE fc4712b..00f394e

https://chromium.googlesource.com/angle/angle.git/+log/fc4712b..00f394e

BUG= 594509 

TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1810773002

Cr-Commit-Position: refs/heads/master@{#381979}

[modify] https://crrev.com/c91724efe5e917f992a85bdf358602ac1046cddf/DEPS

Comment 6 by cwallez@chromium.org, Mar 18 2016

Cc: nyerramilli@chromium.org ranjitkan@chromium.org cwallez@chromium.org
 Issue 594494  has been merged into this issue.

Comment 7 by cwallez@chromium.org, Mar 18 2016

Labels: ReleaseBlock-Beta

Comment 8 by cwallez@chromium.org, Mar 22 2016

Status: Fixed (was: Assigned)
The revert has been merged in and rolled before the beta cutoff. Closing this issue.
►

Sign in to add a comment