Last week, I reviewed https://codereview.chromium.org/1784193003/diff/100002/content/common/gpu/media/gpu_video_decode_accelerator.cc#newcode465. I thought it was odd, because without the explicit template parameter to make_scoped_ptr, the code did not compile.

It turns out this is because media::VDA and media::VEA have custom deleters. I investigated if it would be possible to remove them, but some implementations to take advantage of async delete: https://code.google.com/p/chromium/codesearch#chromium/src/content/common/gpu/media/vt_video_decode_accelerator_mac.cc&sq=package:chromium&l=1128&q=VTVideoDecodeAccelerator::Destroy

However, because the classes derived from VDA and VEA do not have custom deleters themselves, that means that code like this:
  scoped_ptr<DerivedFromVDA> vda(new DerivedFromVDA);

will call the destructor directly instead of using Destroy(). If the Destroy() semantics are important, then this becomes a bug.

Some options:
1) We should get rid of Destroy() and require that deletion of this object always take place via a posted task (e.g. via a helper such as DeleteSoon).
2) Derived subclasses need to have custom deleters as well.

P.S.
I also noticed some weird code like https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/media/rtc_video_decoder.cc&l=682&cl=GROK and https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/media/rtc_video_decoder.cc&l=706&cl=GROK. This should just call vda_.reset().