New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 594465 link

Starred by 1 user
Status: Fixed
Owner:
cbiesin...@chromium.org
Closed: Mar 2016
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
█ rnimmagadda@chromium.org
█ ranjitkan@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary horizontal scroll bar is seen in console text box of chrome://tracing.

Reported by jshan...@etouch.net, Mar 14 2016 
Chrome Version: 51.0.2676.0 (Official Build) a15e4f0ac7ec67afd93957fa56f1ef027ec3775a-refs/heads/master@{#380871}-32/64 bit
OS: All(Win 7-Aero enabled)

Steps:
1. Launch Chrome and navigate to chrome://settings
2. Click on ">>” (chevron) icon to open console text box. 
3. Type some text like 'abc', hit 'Enter' key and observe.

Actual: Unnecessary horizontal scroll bar is seen in console text box. 

Expected: Horizontal scroll bar should not be seen in console text box.

This is a regression issue broken in M-50, below is bisect info

Good build: 50.0.2660.0

Bad build: 50.0.2661.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/19c030e8689cd94f5bc43fcce349e86e4d1ea405..8a3777d77af8e154f4eb03bfa87a8c73b58fa880?pretty=fuller&n=100

Suspecting: r377826 ?

Please help to reassign if your change is not the cause.
Actual_Expected_result.jpg
181 KB View Download

Comment 1 by ranjitkan@chromium.org, Mar 14 2016

Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 2 by jshan...@etouch.net, Mar 14 2016

Labels: -hasTestcase hasbisect

Comment 3 by rnimmagadda@chromium.org, Mar 16 2016

Cc: rnimmagadda@chromium.org
Unable to repro this issue on MAC (10.11.3) for Google Chrome Canary Version - 51.0.2679.0

But, able to repro this issue on Windows 7 & Ubuntu Trusty (14.04) for Google Chrome Canary Version - 51.0.2679.0

@jshanbal: Could you please have a look at the attached screen-recording and confirm if this is the behavior.

Windows & Linux - That bar (displayed in the pic above) is displayed only for the first time, from second time it is disappeared.

Screen-recording & Screen-shot are attached.

Thank you.
594465.mp4
427 KB Download
MAC.png
102 KB View Download

Comment 4 by cbiesin...@chromium.org, Mar 17 2016 

mostly-reduced testcase (no external dependencies)
trace_viewer.html
2.7 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbb25cec59deb052604d63036f1c5baf6efd2a5c

commit fbb25cec59deb052604d63036f1c5baf6efd2a5c
Author: cbiesinger <cbiesinger@chromium.org>
Date: Fri Mar 18 20:40:05 2016

Set m_{width,height}AvailableToChildrenChanged when scrollbars appear

This is a regression from https://codereview.chromium.org/1734203002. Before
that change, we'd just call layoutBlock(true). However, the new approach
just marks for layout and eventually recurses down, so to ensure that
the children get laid out, we have to set
m_{width,height}AvailableToChildrenChanged.

BUG= 594465 , 593593 , 590683 , 593624 , 593593 

Review URL: https://codereview.chromium.org/1811753003

Cr-Commit-Position: refs/heads/master@{#382074}

[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos-expected.html
[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos.html
[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-expected.html
[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes.html
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/layout/LayoutBlock.h
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Comment 7 by cbiesin...@chromium.org, Mar 18 2016

Labels: Merge-Request-50
Status: Fixed (was: Assigned)

Comment 8 by tin...@google.com, Mar 19 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 21 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f4a99dd2428b2395fff7db0330a4c9280054162

commit 7f4a99dd2428b2395fff7db0330a4c9280054162
Author: Christian Biesinger <cbiesinger@chromium.org>
Date: Mon Mar 21 20:04:39 2016

Set m_{width,height}AvailableToChildrenChanged when scrollbars appear

This is a regression from https://codereview.chromium.org/1734203002. Before
that change, we'd just call layoutBlock(true). However, the new approach
just marks for layout and eventually recurses down, so to ensure that
the children get laid out, we have to set
m_{width,height}AvailableToChildrenChanged.

BUG= 594465 , 593593 , 590683 , 593624 , 593593 

Review URL: https://codereview.chromium.org/1811753003

Cr-Commit-Position: refs/heads/master@{#382074}
(cherry picked from commit fbb25cec59deb052604d63036f1c5baf6efd2a5c)

Review URL: https://codereview.chromium.org/1819993002 .

Cr-Commit-Position: refs/branch-heads/2661@{#324}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos-expected.html
[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos.html
[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-expected.html
[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes.html
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/layout/LayoutBlock.h
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Comment 12 by tkonch...@chromium.org, Mar 22 2016

Cc: tkonch...@chromium.org
Labels: TE-Verified-M50 TE-Verified-50.0.2661.48
Tested the same on win8.1, mac 10.11 and Linux 14.04 chrome version 50.0.2661.48 - Horizontal scroll bar not seen in console text box.

Fix works as expected

Please find the screenshot
594465.png
164 KB View Download
►

Sign in to add a comment