SharedMemoryTest.* seems flaky |
||
Issue descriptionVersion: 49.0.2623.87 official build checkout with official deps. OS: Windows 8.1 GYP_DEFINES=mini_installer_official_deps=1 target_arch=x64 branding=Chrome buildtype=Official What steps will reproduce the problem? Build chrome official 49.0.2623.0 base_unittests out\Release_x64\base_unittests --gtest_filter=SharedMemoryTest.UnsafeImageSection --gtest_repeat=10 Note: Google Test filter = SharedMemoryTest.UnsafeImageSection [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from SharedMemoryTest [ RUN ] SharedMemoryTest.UnsafeImageSection d:\src\chrome\src\base\memory\shared_memory_unittest.cc(588): error: Value of: file_handle.IsValid() Actual: false Expected: true d:\src\chrome\src\base\memory\shared_memory_unittest.cc(592): error: Value of: section_handle.IsValid() Actual: false Expected: true d:\src\chrome\src\base\memory\shared_memory_unittest.cc(596): error: Value of: shared_memory_open.Open(kTestSectionName, true) Actual: false Expected: true [ FAILED ] SharedMemoryTest.UnsafeImageSection (12 ms) [----------] 1 test from SharedMemoryTest (16 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (27 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] SharedMemoryTest.UnsafeImageSection 1 FAILED TEST This bug is for me to remember to test this again on a more recent build. I just noticed this when I was building and toying with an official 49.0.2623.87 build.
,
Mar 14 2016
Seems I forgot to apply a sharing flag during CreateFile so that concurrent opens of the file fail. Easy fix in theory.
,
Mar 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/699c5f99ffcda70498cf94ba01948261ce5a700d commit 699c5f99ffcda70498cf94ba01948261ce5a700d Author: forshaw <forshaw@chromium.org> Date: Fri Mar 18 23:17:07 2016 Add sharing flag to file open during unsafe image test. This fixes an issue with the unsafe image test when it's run concurrently. Without the sharing flag the open can sometimes fails depending on timing which makes the test flaky. BUG=594462 Review URL: https://codereview.chromium.org/1791383003 Cr-Commit-Position: refs/heads/master@{#382128} [modify] https://crrev.com/699c5f99ffcda70498cf94ba01948261ce5a700d/base/memory/shared_memory_unittest.cc
,
Aug 23
|
||
►
Sign in to add a comment |
||
Comment 1 by wfh@chromium.org
, Mar 14 2016