New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594447 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Add counters for <label>

Project Member Reported by tkent@chromium.org, Mar 14 2016

Issue description

This is a tracking bug for counters for https://github.com/whatwg/html/issues/787.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39e402647a842f4fcc12faded11d486aca8eda47

commit 39e402647a842f4fcc12faded11d486aca8eda47
Author: tkent <tkent@chromium.org>
Date: Mon Mar 14 06:06:47 2016

Add three UseCounters for LABEL element.

HTMLLabelElementFormIsDifferentFromControlForm:
HTMLLabelElementHasNoControlAndFormIsAncestor:
  They are for label[form] deprecation.
  https://github.com/whatwg/html/issues/787

HTMLLabelElementControlForNonFormAssociatedElement
  This is for a LABEL with PROGRESS or METER.
  This is counted on any LABEL-specific behaviors.
  e.g.  |form| IDL access, |control| IDL access, Clicking a LABEL, etc.

This CL has no user-visible behavior changes.

BUG= 594447 
TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/1790143004

Cr-Commit-Position: refs/heads/master@{#380933}

[modify] https://crrev.com/39e402647a842f4fcc12faded11d486aca8eda47/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/39e402647a842f4fcc12faded11d486aca8eda47/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
[modify] https://crrev.com/39e402647a842f4fcc12faded11d486aca8eda47/third_party/WebKit/Source/core/html/HTMLLabelElement.h
[modify] https://crrev.com/39e402647a842f4fcc12faded11d486aca8eda47/third_party/WebKit/Source/core/html/HTMLLabelElement.idl
[modify] https://crrev.com/39e402647a842f4fcc12faded11d486aca8eda47/tools/metrics/histograms/histograms.xml

Comment 2 by tkent@chromium.org, Mar 14 2016

Labels: Merge-Request-50
Status: Fixed (was: Started)

Comment 3 by tkent@chromium.org, Mar 14 2016

Components: -Blink>Forms Blink>Forms>Label

Comment 4 by tin...@google.com, Mar 15 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 15 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1c470bb537ac2c1fe83e8c1f6b3719782033ed9

commit e1c470bb537ac2c1fe83e8c1f6b3719782033ed9
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Mar 15 07:54:41 2016

Add three UseCounters for LABEL element.

HTMLLabelElementFormIsDifferentFromControlForm:
HTMLLabelElementHasNoControlAndFormIsAncestor:
  They are for label[form] deprecation.
  https://github.com/whatwg/html/issues/787

HTMLLabelElementControlForNonFormAssociatedElement
  This is for a LABEL with PROGRESS or METER.
  This is counted on any LABEL-specific behaviors.
  e.g.  |form| IDL access, |control| IDL access, Clicking a LABEL, etc.

This CL has no user-visible behavior changes.

BUG= 594447 
TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/1790143004

Cr-Commit-Position: refs/heads/master@{#380933}
(cherry picked from commit 39e402647a842f4fcc12faded11d486aca8eda47)

Review URL: https://codereview.chromium.org/1802263002 .

Cr-Commit-Position: refs/branch-heads/2661@{#236}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/e1c470bb537ac2c1fe83e8c1f6b3719782033ed9/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/e1c470bb537ac2c1fe83e8c1f6b3719782033ed9/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
[modify] https://crrev.com/e1c470bb537ac2c1fe83e8c1f6b3719782033ed9/third_party/WebKit/Source/core/html/HTMLLabelElement.h
[modify] https://crrev.com/e1c470bb537ac2c1fe83e8c1f6b3719782033ed9/third_party/WebKit/Source/core/html/HTMLLabelElement.idl

Sign in to add a comment