BidirectionalStreamTest#testFailures is flaky |
||||
Issue descriptionThe following run is complaining that "throwOrCancel(FailureType.CANCEL_ASYNC, ResponseStep.ON_REQUEST_HEADERS_SENT, false, false)" is flaky. More specifically, the response info isn't null. The test assertion should be adjusted. Cancel during ResponseStep.ON_REQUEST_HEADERS_SENT step doesn't guarantee that response info is null. Current url: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARMv6%20Builder/builds/1447/steps/Instrumentation%20test%20CronetTestInstrumentation/logs/stdio C 183.084s Main [FAIL] org.chromium.net.BidirectionalStreamTest#testFailures: C 183.084s Main java.lang.Throwable: CronetTestBase#runTest failed. C 183.084s Main at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:147) C 183.084s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 183.084s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 183.084s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) C 183.084s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701) C 183.084s Main Caused by: junit.framework.AssertionFailedError: expected:<false> but was:<true> C 183.084s Main at org.chromium.net.BidirectionalStreamTest.throwOrCancel(BidirectionalStreamTest.java:826) C 183.085s Main at org.chromium.net.BidirectionalStreamTest.testFailures(BidirectionalStreamTest.java:840) C 183.085s Main at java.lang.reflect.Method.invokeNative(Native Method) C 183.085s Main at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:137) C 183.085s Main ... 9 more C 183.085s Main ******************************************************************************** C 183.085s Main Summary C 183.085s Main ******************************************************************************** C 183.086s Main [==========] 281 tests ran. C 183.086s Main [ PASSED ] 280 tests. C 183.086s Main [ FAILED ] 1 test, listed below: C 183.086s Main [ FAILED ] org.chromium.net.BidirectionalStreamTest#testFailures C 183.087s Main C 183.087s Main 1 FAILED TEST C 183.087s Main ******************************************************************************** I 183.087s Main Writing results to /b/build/slave/Android_Cronet_ARMv6_Builder/build/src/out/Release/test_logs/instrumentation.log. C 183.088s Main Instr tests: 0 success, 0 infra, 1 errors, 0 warnings step returned non-zero exit code: 1 @@@STEP_FAILURE@@@
,
Mar 17 2016
,
Mar 18 2016
While waiting for my CLs to get reviewed, I will do this. This is a one liner change.
,
Mar 18 2016
Issue 595546 has been merged into this issue.
,
Mar 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3954c975719d59922ccc6e5935e74748bf63e8e7 commit 3954c975719d59922ccc6e5935e74748bf63e8e7 Author: xunjieli <xunjieli@chromium.org> Date: Tue Mar 22 00:00:40 2016 Fix BidirectionalStreamTest#testFailures flake Cancel during ResponseStep.ON_REQEST_HEADERS_SENT does not guarantee that mResponseInfo will be null, because an onResponseHeadersReceived callback might already been queued at the executor. BUG= 594432 Review URL: https://codereview.chromium.org/1815163003 Cr-Commit-Position: refs/heads/master@{#382444} [modify] https://crrev.com/3954c975719d59922ccc6e5935e74748bf63e8e7/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
,
Mar 22 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by xunji...@chromium.org
, Mar 17 2016