New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 594423 link

Starred by 1 user
Status: Fixed
Owner:
shaktisahu@chromium.org
Closed: May 2016
Cc:
w...@chromium.org
█ nyquist@chromium.org
kmarshall@chromium.org
dtrainor@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 597789



Sign in to add a comment

Blimp 0.5 client: Debug info

Project Member Reported by mdw@chromium.org, Mar 13 2016 
The Blimp 0.5 client should have some kind of a debug info screen (akin to chrome://net-internals) with details on the connection to the engine, which engine is in use, counts of messages sent/received, and other useful information for diagnosing problems. Ideally, we should also be able to save a log of messages between the client and engine which can be used for debugging.

Comment 1 by dtrainor@chromium.org, Mar 14 2016

Cc: nyquist@chromium.org shaktisahu@chromium.org kmarshall@chromium.org w...@chromium.org
CC'ing relevant parties who might be interested in how this is implemented and what we log.  I like the list above.  I think we could start with something simple to get the infrastructure up.  I'll list out what I think we should add (basically taking the above and putting it into list form :)).

- Connection status (if failure, recent connection attempt failure reason).
- Engine IP and version.
- Message send/receive counts (both # of messages and bytes).  Total and per channel?

Comment 2 by dtrainor@chromium.org, Mar 14 2016 

Related to 594427.

Comment 3 by dtrainor@chromium.org, Mar 15 2016

Cc: -shaktisahu@chromium.org dtrainor@chromium.org
Owner: shaktisahu@chromium.org

Comment 4 by w...@chromium.org, Mar 22 2016

Components: Mobile>Blimp>Client
Labels: -Proj-Blimp

Comment 5 by w...@chromium.org, Apr 1 2016

Blocking: 597790
Labels: M-52

Comment 6 by amineer@chromium.org, Apr 13 2016

Labels: Blimp-M52-Proj-Scope

Comment 7 by nyquist@chromium.org, May 12 2016

Blocking: -597790 597789
Labels: -M-52 M-53

Comment 8 by shaktisahu@chromium.org, May 16 2016

Status: Started (was: Assigned)

Comment 10 by amineer@chromium.org, May 25 2016

Labels: Blimp-M53-Proj-Scope
[Bulk edit]

Setting tracking label Blimp-M53-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-53 scope, or remove this bug from M-53 scope.
Project Member

Comment 11 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03e5b0d97aa1fc6e813725465142978896ed8641

commit 03e5b0d97aa1fc6e813725465142978896ed8641
Author: shaktisahu <shaktisahu@chromium.org>
Date: Wed May 25 18:06:59 2016

Added a debug info UI for Blimp

Added a menu option in toolbar to show/hide debug info. When enabled,
an overlay debug UI would be shown on the bottom left of the screen
showing number of commits, and kilobytes sent and received by the client.
This data is reset when the user moves away or is redirected to a new
page.

BUG= 594423 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1962393004
Cr-Commit-Position: refs/heads/master@{#395931}

[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/BUILD.gn
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/app/android/blimp_client_session_android.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/app/android/blimp_client_session_android.h
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/app/android/blimp_view.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/app/android/blimp_view.h
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/app/android/java/res/layout/blimp_main.xml
[add] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/app/android/java/res/layout/debug_stats_overlay.xml
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/app/android/java/src/org/chromium/blimp/session/BlimpClientSession.java
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/app/android/java/src/org/chromium/blimp/toolbar/Toolbar.java
[add] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/app/android/java/src/org/chromium/blimp/toolbar/ToolbarMenu.java
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/app/android/java/strings/android_blimp_strings.grd
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/app/linux/blimp_display_manager.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/app/linux/blimp_display_manager.h
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/feature/compositor/blimp_compositor.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/feature/compositor/blimp_compositor.h
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/feature/compositor/blimp_compositor_manager.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/feature/compositor/blimp_compositor_manager.h
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/feature/compositor/blimp_compositor_unittest.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/session/blimp_client_session.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/client/session/blimp_client_session.h
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/BUILD.gn
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/blimp_connection.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/blimp_connection.h
[add] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/blimp_connection_statistics.cc
[add] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/blimp_connection_statistics.h
[add] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/blimp_connection_statistics_unittest.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/ssl_client_transport.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/ssl_client_transport.h
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/ssl_client_transport_unittest.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/stream_packet_reader.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/stream_packet_reader.h
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/stream_packet_reader_unittest.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/stream_packet_writer.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/stream_packet_writer.h
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/stream_packet_writer_unittest.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/stream_socket_connection.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/stream_socket_connection.h
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/tcp_client_transport.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/tcp_client_transport.h
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/tcp_engine_transport.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/tcp_engine_transport.h
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/blimp/net/tcp_transport_unittest.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/cc/trees/remote_channel_impl.cc
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/cc/trees/remote_channel_impl.h
[modify] https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641/cc/trees/remote_channel_unittest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, May 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/955c7d93dd9852ae93a3d8e9b1fd396c37baf361

commit 955c7d93dd9852ae93a3d8e9b1fd396c37baf361
Author: haibinlu <haibinlu@chromium.org>
Date: Thu May 26 01:15:16 2016

Revert of Added a debug info UI for Blimp (patchset #12 id:220001 of https://codereview.chromium.org/1962393004/ )

Reason for revert:
 crbug.com/614888  broken blimp browsertest on fyi bot.

Original issue's description:
> Added a debug info UI for Blimp
>
> Added a menu option in toolbar to show/hide debug info. When enabled,
> an overlay debug UI would be shown on the bottom left of the screen
> showing number of commits, and kilobytes sent and received by the client.
> This data is reset when the user moves away or is redirected to a new
> page.
>
> BUG= 594423 
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641
> Cr-Commit-Position: refs/heads/master@{#395931}

TBR=kmarshall@chromium.org,khushalsagar@chromium.org,vmpstr@chromium.org,shaktisahu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 594423 

Review-Url: https://codereview.chromium.org/2008283004
Cr-Commit-Position: refs/heads/master@{#396073}

[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/BUILD.gn
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/app/android/blimp_client_session_android.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/app/android/blimp_client_session_android.h
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/app/android/blimp_view.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/app/android/blimp_view.h
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/app/android/java/res/layout/blimp_main.xml
[delete] https://crrev.com/0f99c178e15f6db8e3c5b057acdefd657632af0c/blimp/client/app/android/java/res/layout/debug_stats_overlay.xml
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/app/android/java/src/org/chromium/blimp/session/BlimpClientSession.java
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/app/android/java/src/org/chromium/blimp/toolbar/Toolbar.java
[delete] https://crrev.com/0f99c178e15f6db8e3c5b057acdefd657632af0c/blimp/client/app/android/java/src/org/chromium/blimp/toolbar/ToolbarMenu.java
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/app/android/java/strings/android_blimp_strings.grd
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/app/linux/blimp_display_manager.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/app/linux/blimp_display_manager.h
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/feature/compositor/blimp_compositor.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/feature/compositor/blimp_compositor.h
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/feature/compositor/blimp_compositor_manager.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/feature/compositor/blimp_compositor_manager.h
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/feature/compositor/blimp_compositor_unittest.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/session/blimp_client_session.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/client/session/blimp_client_session.h
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/BUILD.gn
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/blimp_connection.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/blimp_connection.h
[delete] https://crrev.com/0f99c178e15f6db8e3c5b057acdefd657632af0c/blimp/net/blimp_connection_statistics.cc
[delete] https://crrev.com/0f99c178e15f6db8e3c5b057acdefd657632af0c/blimp/net/blimp_connection_statistics.h
[delete] https://crrev.com/0f99c178e15f6db8e3c5b057acdefd657632af0c/blimp/net/blimp_connection_statistics_unittest.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/ssl_client_transport.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/ssl_client_transport.h
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/ssl_client_transport_unittest.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/stream_packet_reader.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/stream_packet_reader.h
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/stream_packet_reader_unittest.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/stream_packet_writer.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/stream_packet_writer.h
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/stream_packet_writer_unittest.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/stream_socket_connection.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/stream_socket_connection.h
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/tcp_client_transport.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/tcp_client_transport.h
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/tcp_engine_transport.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/tcp_engine_transport.h
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/blimp/net/tcp_transport_unittest.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/cc/trees/remote_channel_impl.cc
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/cc/trees/remote_channel_impl.h
[modify] https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361/cc/trees/remote_channel_unittest.cc
Project Member

Comment 13 by bugdroid1@chromium.org, May 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/086802955ffbe67f0a2de987822ae8d18dd5353d

commit 086802955ffbe67f0a2de987822ae8d18dd5353d
Author: shaktisahu <shaktisahu@chromium.org>
Date: Fri May 27 01:57:30 2016

Reland: Added a debug info UI for Blimp

Added a menu option in toolbar to show/hide debug info. When enabled,
an overlay debug UI would be shown on the bottom left of the screen
showing number of commits, and kilobytes sent and received by the client.
This data is reset when the user moves away or is redirected to a new
page.

BUG= 594423 ,  614888 
TBR=vmpstr@chromium.org

Original CL: https://codereview.chromium.org/1962393004/
Revert CL: https://codereview.chromium.org/2008283004/
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2019463002
Cr-Commit-Position: refs/heads/master@{#396351}

[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/BUILD.gn
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/blimp_client_session_android.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/blimp_client_session_android.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/blimp_view.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/blimp_view.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/java/res/layout/blimp_main.xml
[add] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/java/res/layout/debug_stats_overlay.xml
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/java/src/org/chromium/blimp/session/BlimpClientSession.java
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/java/src/org/chromium/blimp/toolbar/Toolbar.java
[add] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/java/src/org/chromium/blimp/toolbar/ToolbarMenu.java
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/android/java/strings/android_blimp_strings.grd
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/linux/blimp_display_manager.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/app/linux/blimp_display_manager.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/feature/compositor/blimp_compositor.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/feature/compositor/blimp_compositor.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/feature/compositor/blimp_compositor_manager.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/feature/compositor/blimp_compositor_manager.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/feature/compositor/blimp_compositor_unittest.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/session/blimp_client_session.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/client/session/blimp_client_session.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/BUILD.gn
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/blimp_connection.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/blimp_connection.h
[add] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/blimp_connection_statistics.cc
[add] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/blimp_connection_statistics.h
[add] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/blimp_connection_statistics_unittest.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/ssl_client_transport.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/ssl_client_transport.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/ssl_client_transport_unittest.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_packet_reader.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_packet_reader.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_packet_reader_unittest.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_packet_writer.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_packet_writer.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_packet_writer_unittest.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_socket_connection.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/stream_socket_connection.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/tcp_client_transport.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/tcp_client_transport.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/tcp_engine_transport.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/tcp_engine_transport.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/blimp/net/tcp_transport_unittest.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/cc/trees/remote_channel_impl.cc
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/cc/trees/remote_channel_impl.h
[modify] https://crrev.com/086802955ffbe67f0a2de987822ae8d18dd5353d/cc/trees/remote_channel_unittest.cc

Comment 14 by shaktisahu@chromium.org, May 31 2016

Status: Fixed (was: Started)

Comment 15 by amineer@chromium.org, Dec 9 2016

Labels: Archive-Blimp
►

Sign in to add a comment