New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594419 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

error from mojo when running interactive_ui_tests

Project Member Reported by wfh@chromium.org, Mar 13 2016

Issue description

<b>Version: <Kenneth, what is the frequency?></b>
OS: Windows 8.1

What steps will reproduce the problem?
(1) Run interactive_ui_tests.exe

D:\src\gclient\src>out\RElease_x64\interactive_ui_tests.exe --gtest_filter=BrowserActionInteractiveTest.BrowserClickClosesPopup2
IMPORTANT DEBUGGING NOTE: each test is run inside its own process.
For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with either
--single_process (to run the test in one launcher/browser process) or
--single-process (to do the above, and also run Chrome in single-process mode).
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = BrowserActionInteractiveTest.BrowserClickClosesPopup2
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from BrowserActionInteractiveTest, where TypeParam =
[ RUN      ] BrowserActionInteractiveTest.BrowserClickClosesPopup2
[15268:14816:0313/143409:ERROR:shell.cc(265)] Error: Instance: exe:chrome attempting to register an instance for a process it created for target: exe:chrome_renderer without the mojo:shell{client_process} capability class.
[15268:14816:0313/143410:ERROR:shell.cc(265)] Error: Instance: exe:chrome attempting to register an instance for a process it created for target: exe:chrome_renderer without the mojo:shell{client_process} capability class.
[       OK ] BrowserActionInteractiveTest.BrowserClickClosesPopup2 (929 ms)
[----------] 1 test from BrowserActionInteractiveTest (930 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (931 ms total)
[  PASSED  ] 1 test.
[1/1] BrowserActionInteractiveTest.BrowserClickClosesPopup2 (967 ms)
SUCCESS: all tests passed.

this is the error:

[15268:14816:0313/143410:ERROR:shell.cc(265)] Error: Instance: exe:chrome attempting to register an instance for a process it created for target: exe:chrome_renderer without the mojo:shell{client_process} capability class.

coming from ValidateClientProcessConnection in mojo/shell/shell.cc

https://code.google.com/p/chromium/codesearch#chromium/src/mojo/shell/shell.cc&sq=package:chromium&l=259

if this is an error then it should be fixed. If this is not an error then it shouldn't be printing.
 

Comment 1 by mmi...@gmail.com, Mar 17 2016

I am getting this error just by running Chromium latest master on Mac OS X, so no tests, just using it.

Comment 2 by roc...@chromium.org, Mar 17 2016

Cc: roc...@chromium.org
The error is harmless but noisy. It's caused by chrome_manifest.json not being present alongside the executable. Two problems here really:

 1. We need the manifests in isolates
 2. We should be shipping the manifests with Chrome binaries now

Currently the only side effect of a missing manifest is this error spam, but that should be changing sooner rather than later.

Comment 3 by wfh@chromium.org, Mar 21 2016

What is the eta on fixing this error? can it be changed to a WARNING or INFO until the manifest is shipped?

Comment 4 by roc...@chromium.org, Mar 21 2016

I'll demote it to WARNING for now.

Comment 5 by jam@chromium.org, Mar 22 2016

From discussions with Ken and Ben, I prefer that the manifests get bundled into the resources file. That way this implementation detail (mojo manifests) doesn't leak into the final shipping product.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07b3e034d356a9d3629a82041473d6db785a507d

commit 07b3e034d356a9d3629a82041473d6db785a507d
Author: rockot <rockot@chromium.org>
Date: Tue Mar 22 16:29:08 2016

Demote Mojo shell errors to warnings

Until we have application manifests sorted out in production
these messages are too spammy to be errors.

BUG= 594419 
R=jam@chromium.org

Review URL: https://codereview.chromium.org/1824553004

Cr-Commit-Position: refs/heads/master@{#382583}

[modify] https://crrev.com/07b3e034d356a9d3629a82041473d6db785a507d/mojo/shell/shell.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5

commit 00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5
Author: rockot <rockot@chromium.org>
Date: Thu Apr 07 18:56:23 2016

Load application manifests from resources

- Renames content's builtin apps to content_browser and content_renderer
- Supports loading manifests from resources instead of files
- Derives chrome's manifests from content's without duplicating metadata
- Avoids all filesystem lookups for existing apps in content today
- Ensures all content embedders have a working shell connection with capabilities

BUG= 594419 

Review URL: https://codereview.chromium.org/1828733004

Cr-Commit-Position: refs/heads/master@{#385823}

[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/chrome/app/BUILD.gn
[add] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/chrome/app/mojo/chrome_manifest.json
[add] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/chrome/app/mojo/chrome_renderer_manifest.json
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/content/BUILD.gn
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/content/browser/BUILD.gn
[delete] https://crrev.com/9d1960a45d22938a3deb641657d8e21f5ff7b76b/content/browser/mojo/chrome_renderer_manifest.json
[add] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/content/browser/mojo/constants.cc
[add] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/content/browser/mojo/constants.h
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/content/browser/mojo/mojo_child_connection.cc
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/content/browser/mojo/mojo_shell_context.cc
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/content/browser/mojo/mojo_shell_context.h
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/content/content.gyp
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/content/content_browser.gypi
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/content/content_resources.grd
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/content/content_resources.gypi
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/content/public/app/BUILD.gn
[rename] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/content/public/app/mojo/content_browser_manifest.json
[add] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/mojo/mojo_shell.gyp
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/mojo/public/mojo_application_manifest.gni
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/mojo/public/mojo_application_manifest.gypi
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/mojo/public/tools/manifest/manifest_collator.py
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/mojo/services/catalog/BUILD.gn
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/mojo/services/catalog/catalog.cc
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/mojo/services/catalog/catalog.h
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/mojo/services/catalog/factory.cc
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/mojo/services/catalog/factory.h
[add] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/mojo/services/catalog/manifest_provider.h
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/mojo/shell/shell.cc
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/mojo/shell/standalone/context.cc
[modify] https://crrev.com/00668f9780a1b1c6c1b1a1f2457418d0aecf9bb5/mojo/shell/tests/loader_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/789f26c9d398df3f48dc39541f3a8238a96fad4b

commit 789f26c9d398df3f48dc39541f3a8238a96fad4b
Author: sadrul <sadrul@chromium.org>
Date: Tue Apr 12 00:13:57 2016

mash: Make sure the app-manifests for chrome gets built.

BUG= 594419 ,  601983 

Review URL: https://codereview.chromium.org/1870393002

Cr-Commit-Position: refs/heads/master@{#386528}

[modify] https://crrev.com/789f26c9d398df3f48dc39541f3a8238a96fad4b/chrome/BUILD.gn

Comment 9 by ben@chromium.org, Aug 16 2016

Status: Fixed (was: Assigned)

Sign in to add a comment