BrowserActionInteractiveTest.TabSwitchClosesPopup fails win8 win10 |
||||||
Issue description
Version: 51.0.2676.0 rev f751bddca167
OS: I tested Win 8.1 and Win 10
What steps will reproduce the problem?
GYP_DEFINES=chromium_win_pch=0 component=static_library fastbuild=1 gomadir='D:\src\goma\goma-win64' target_arch=x64 use_goma=1
out\Release_x64\interactive_ui_tests.exe --gtest_filter=BrowserActionInteractiveTest.TabSwitchClosesPopup
Note: Google Test filter = BrowserActionInteractiveTest.TabSwitchClosesPopup
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from BrowserActionInteractiveTest, where TypeParam =
[ RUN ] BrowserActionInteractiveTest.TabSwitchClosesPopup
[10272:13148:0313/130610:ERROR:shell.cc(265)] Error: Instance: exe:chrome attempting to register an instance for a process it created for target: exe:chrome_renderer without the mojo:shell{client_process} capability class.
[10272:13148:0313/130610:ERROR:shell.cc(265)] Error: Instance: exe:chrome attempting to register an instance for a process it created for target: exe:chrome_renderer without the mojo:shell{client_process} capability class.
[10272:13148:0313/130610:ERROR:shell.cc(265)] Error: Instance: exe:chrome attempting to register an instance for a process it created for target: exe:chrome_renderer without the mojo:shell{client_process} capability class.
d:\src\gclient\src\chrome\browser\extensions\api\extension_action\browser_action_interactive_test.cc(296): error: Value
of: BrowserActionTestUtil(browser()).HasPopup()
Actual: true
Expected: false
[ FAILED ] BrowserActionInteractiveTest.TabSwitchClosesPopup, where TypeParam = and GetParam() = (730 ms)
[----------] 1 test from BrowserActionInteractiveTest (730 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (731 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] BrowserActionInteractiveTest.TabSwitchClosesPopup, where TypeParam = and GetParam() =
,
Mar 13 2016
Actually, scratch that, it compiles it on "Win8 Aura" but doens't seem to run it. So perhaps this has been failing for a while. We don't seem to have any interactive_ui_tests coverage on Win8 or Win10...?
,
Mar 13 2016
So yes, it seems they don't work on win8 either - https://codereview.chromium.org/1795853002 and we've just never had any test coverage.
,
Mar 13 2016
Devlin, who's handling browser actions these days?
,
Mar 13 2016
,
Mar 14 2016
though not exact that test, same error message on fedora 22 x86 normal first run after build. Chromium 51.0.2677.0 (개발자 빌드) custom (32비트) 개정 bc6d3a094cbcd748ad14b8d73bfa571ef101cc07-refs/heads/master@{#380896} [2132:2132:0314/151943:ERROR:shell.cc(265)] Error: Instance: exe:chrome attempting to register an instance for a process it created for target: exe:chrome_renderer without the mojo:shell{client_process} capability class.
,
Mar 14 2016
I think the mojo shell error is something unrelated to this issue. see issue 594419
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dbedd030a19e84b9f5cc366daea1ea20556d5c0 commit 3dbedd030a19e84b9f5cc366daea1ea20556d5c0 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 15 00:13:34 2016 [Extensions] Fix BrowserActionInteractiveTest.TabSwitchClosesPopup BUG= 594417 Review URL: https://codereview.chromium.org/1799223002 Cr-Commit-Position: refs/heads/master@{#381125} [modify] https://crrev.com/3dbedd030a19e84b9f5cc366daea1ea20556d5c0/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc
,
Mar 15 2016
When I ran the CL to fix this (https://codereview.chromium.org/1799223002) through win8 with interactive_ui_tests enabled, it all looked good. I think it's fixed. Feel free to re-open if it turns out it's not.
,
Mar 15 2016
thanks for fixing this so quickly. I am now enabling interactive_ui_tests on the win8 trybot, and the win10 fyi bot.
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a8e1ace81a75681667d5475ffb9558f3bb520fc commit 1a8e1ace81a75681667d5475ffb9558f3bb520fc Author: wfh <wfh@chromium.org> Date: Tue Mar 15 03:32:33 2016 Add interactive_ui_tests to Windows 10 fyi bot. BUG= 508743 , 594417 Review URL: https://codereview.chromium.org/1799343002 Cr-Commit-Position: refs/heads/master@{#381166} [modify] https://crrev.com/1a8e1ace81a75681667d5475ffb9558f3bb520fc/testing/buildbot/chromium.fyi.json
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e040041ab6a37553a6feb5717472926c4fa4bc9d commit e040041ab6a37553a6feb5717472926c4fa4bc9d Author: wfh <wfh@chromium.org> Date: Tue Mar 15 03:32:56 2016 Add interactive_ui_tests to Win8 Aura config. BUG=373973, 594417 Review URL: https://codereview.chromium.org/1795853002 Cr-Commit-Position: refs/heads/master@{#381167} [modify] https://crrev.com/e040041ab6a37553a6feb5717472926c4fa4bc9d/testing/buildbot/chromium.win.json
,
Mar 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbd4ec4edc6087a29aa7e6bbde8c983ef2fa8439 commit fbd4ec4edc6087a29aa7e6bbde8c983ef2fa8439 Author: sky <sky@chromium.org> Date: Mon Mar 21 17:53:33 2016 Revert of Add interactive_ui_tests to Win8 Aura config. (patchset #1 id:1 of https://codereview.chromium.org/1795853002/ ) Reason for revert: interactive_ui_tests don't run well on win8 machines yet. See http://crbug.com/595071 . Reverting until sorted out. Original issue's description: > Add interactive_ui_tests to Win8 Aura config. > > BUG=373973, 594417 > > Committed: https://crrev.com/e040041ab6a37553a6feb5717472926c4fa4bc9d > Cr-Commit-Position: refs/heads/master@{#381167} TBR=dpranke@chromium.org,wfh@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=373973, 594417 ,595071 Review URL: https://codereview.chromium.org/1823583003 Cr-Commit-Position: refs/heads/master@{#382322} [modify] https://crrev.com/fbd4ec4edc6087a29aa7e6bbde8c983ef2fa8439/testing/buildbot/chromium.win.json
,
Mar 21 2016
FWIW, this bug sounds like a fallout of https://codereview.chromium.org/1544803004 I had to handle BrowserActionInteractiveTest.TabSwitchClosesPopup separately for that CL which might have broken things on Win8 and/or Win10. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by wfh@chromium.org
, Mar 13 2016