GN does not rebuild entire APK when making native only change |
||
Issue descriptionRepro steps: 1) gn gen out/gn_Debug --args='use_goma=true is_clang=true is_component_build=true target_os="android"' 2) Build chrome_public_apk and deploy to device 3) Add LOG() statement somewhere in native (I put one in NavigationControllerImpl::RendererDidNavigate) 4) Build chrome_public_apk again and deploy to device Expected: Log message is printed for each navigation Actual: No log message is printed. If I make a random change in Java in addition to the native change and rebuild, chrome_public_apk is fully rebuilt and a log message is printed for each navigation
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57956cfb1d18e674f5fca36858f9336b0172f3c9 commit 57956cfb1d18e674f5fca36858f9336b0172f3c9 Author: agrieve <agrieve@chromium.org> Date: Tue Mar 15 18:12:41 2016 GN: Fix ChromePublic.apk not rebuilding for native changes It was not being rebuilt when is_component_build=true, and the only change to the .apk's inputs was to an indirect .cr.so file. BUG= 594409 Review URL: https://codereview.chromium.org/1802853002 Cr-Commit-Position: refs/heads/master@{#381253} [modify] https://crrev.com/57956cfb1d18e674f5fca36858f9336b0172f3c9/build/android/gyp/write_build_config.py
,
Mar 15 2016
,
Mar 16 2016
Thank you very much for fixing the bug! (Even though I kind of randomly assigned i to you) I really appreciate it. |
||
►
Sign in to add a comment |
||
Comment 1 by pkotw...@chromium.org
, Mar 13 2016Status: Assigned (was: Untriaged)