Nothing we can really do, based on how the Android API works.  Best we can do is say "Site sent to your home screen" or something.  Is this a string worth changing, Rebecca?  We keep getting bugs for situations where the launchers don't do anything when we ask them to.

So we wouldn't even know you're out of room on your home screen (to say something like "Not enough space to add site")?

Nope.  The "API" (if you can call it that) involves firing an Intent as a general broadcast.  This means that any/all/none of the launchers on the device registered as receivers for the Intent may or may not handle the Intent.  It's also why we don't know if anything answered our shortcut adding request.

Fun fact: people installing a second launcher on their devices can often result in both launchers adding the shortcuts to their home screens.

Doubly fun fact: sometimes the AGSA will refuse to add the shortcut until they are relaunched, upon which the user will randomly slide over to another home screen and see the icon be added.

Triply fun fact: Samsung's launcher [used to/still does] fire a toast saying that something was added to your home screen after our own Toast, so users got a double dose of Toast.

(+ owencm to give the OK)

Fourth fact: Seems like "<site name> was added to your Home screen" is not a helpful confirmation!

I don't know that a ton of people install two launchers but AGSA is an app we want to work nicely with and we have significant number of Samsung users.

owencm - would it be OK or too weird to change the confirmation to say:
"Request sent to add this site to your Home screen"

Yeah it is a shame we can't know the true result in this case, and that there's so many nasty edge cases.

That said, I think that the value of a clear string that is right > 90% of the time is better than one that's confusing 100% of the time.

This unfortunately looks like a WontFix to me unless we can find some other way of determining whether it was added etc. 

Dan - I guess in the Samsung case we may be able to detect their launcher and suppress our toast, if we think it's important enough, but that should probably be a new issue.

That's assuming that a user is using a secondary launcher, or that we can identify when their launcher actually fires their toast :/  I don't think it's a super big deal if the user gets a double toast, though.

I can settle for Wontfix, although I'm open to any other alternative for sure. If we're wrong even 1 time out of 10 it impacts the trustworthiness of the other nine times.

We could just not toast at all, and do some other thing like show the progress loader to simulate a page refresh. I wish we could know when we failed specifically - that would be way more helpful but isn't available to us. Bummer!

Yeah, would settle with WontFix, too :/  Showing the progress loader seems less intuitive to me, because it would just look like the page is being reloaded.

Sounds like we're all in sad agreement here. 

If anyone thinks of a great idea on how to solve any of these cases then lets reopen, otherwise marking as WontFix.