New issue
Advanced search Search tips

Issue 594361 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 82385



Sign in to add a comment

Clang ToT Windows bots broken after MSVS2015 switch

Project Member Reported by thakis@chromium.org, Mar 12 2016

Issue description

All Windows bots on https://build.chromium.org/p/chromium.fyi/console?category=clang%20tot are unhappy after the MSVS2015 switch.

Errors looks like so:

FAILED: C:\b\depot_tools\win_toolchain\vs2013_files\4087e065abebdca6dbd0caca2910c6718d2ec67f\VC\bin\amd64\cl.exe   /nologo /TP -DLLVM_FORCE_HEAD_REVISION -DLLVM_FORCE_HEAD_REVISION /W4 -wd4141 -wd4146 -wd4180 -wd4244 -wd4258 -wd4267 -wd4291 -wd4345 -wd4351 -wd4355 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4800 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4324 -w14062 -we4238 /Zc:inline /Oi /Zc:rvalueCast /MD /O2 /Ob2 -Ilib\Support -IC:\b\build\slave\ClangToTWin\build\src\third_party\llvm\lib\Support -Iinclude -IC:\b\build\slave\ClangToTWin\build\src\third_party\llvm\include    -UNDEBUG  /EHs-c- /GR- /showIncludes -DGTEST_HAS_RTTI=0 -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_DEBUG_POINTER_IMPL="" -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS /Folib\Support\CMakeFiles\LLVMSupport.dir\Triple.cpp.obj /Fdlib\Support\CMakeFiles\LLVMSupport.dir\ /FS -c C:\b\build\slave\ClangToTWin\build\src\third_party\llvm\lib\Support\Triple.cpp
C:\b\depot_tools\win_toolchain\vs_files\391bbf1220d3edcd3cc3fccdb56224181e3b13a7\win_sdk\bin\..\..\VC\include\initializer_list(27) : error C2146: syntax error : missing ';' before identifier 'initializer_list'
        C:\b\depot_tools\win_toolchain\vs_files\391bbf1220d3edcd3cc3fccdb56224181e3b13a7\win_sdk\bin\..\..\VC\include\initializer_list(56) : see reference to class template instantiation 'std::initializer_list<_Elem>' being compiled
C:\b\depot_tools\win_toolchain\vs_files\391bbf1220d3edcd3cc3fccdb56224181e3b13a7\win_sdk\bin\..\..\VC\include\initializer_list(27) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
C:\b\depot_tools\win_toolchain\vs_files\391bbf1220d3edcd3cc3fccdb56224181e3b13a7\win_sdk\bin\..\..\VC\include\initializer_list(32) : error C2146: syntax error : missing ';' before identifier 'initializer_list'



It looks like it picks up the 2013 compiler but 2015 headers, which of course doesn't work.

I attempted to fix this with https://codereview.chromium.org/1790433009/ but that didn't help. Maybe it's cmake caching the compiler? I thought we tried to clear cmake caches on every build, but maybe we're missing one?
 

Comment 1 by h...@chromium.org, Mar 14 2016

Owner: h...@chromium.org
Status: Started (was: Untriaged)
> Maybe it's cmake caching the compiler? I thought we tried to clear cmake caches on every build, but maybe we're missing one?

Yeah, I believe this is it. I can reproduce locally that the compiler is getting cached. Trying to fix with https://codereview.chromium.org/1794333003/
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16ae62ebdbef46d3cb638eb43ed9a0e6b2558e8d

commit 16ae62ebdbef46d3cb638eb43ed9a0e6b2558e8d
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Mar 14 10:41:44 2016

Clang update.py: clobber more CMake cache files

The compiler info seems to get cached under CMakeFiles/3.2.2/CompilerId*.
To clobber things properly, let's nuke any CmakeFiles dirs.

BUG= 594361 
R=thakis@chromium.org
TBR=thakis

Review URL: https://codereview.chromium.org/1794333003 .

Cr-Commit-Position: refs/heads/master@{#380953}

[modify] https://crrev.com/16ae62ebdbef46d3cb638eb43ed9a0e6b2558e8d/tools/clang/scripts/update.py

Comment 3 by h...@chromium.org, Mar 14 2016

Status: Fixed (was: Started)
First green build: https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/7019

Sign in to add a comment