chrome_elf_unittests broken in component builds after VS2015 switch |
||
Issue descriptionI'm seeing this on the release component clang-cl bots, but I'm guessing it would happen with MSVC too, we just don't have release component bots running tests on the main waterfall. https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28shared%29%20tester/builds/3860 https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dll%29%20tester/builds/2191 ELFImportsTest.ChromeElfSanityCheck (run #1): [ RUN ] ELFImportsTest.ChromeElfSanityCheck ..\..\chrome_elf\elf_imports_unittest.cc(99): error: Value of: match Actual: false Expected: true Illegal import in chrome_elf.dll: VCRUNTIME140.dll [ FAILED ] ELFImportsTest.ChromeElfSanityCheck (1 ms)
,
Mar 14 2016
,
Mar 14 2016
Cool, thanks :-) I verified that this isn't a clang-only problem by now, but that's also obvious from the fix I suppose.
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b3670491a67a5ab16a3df58bfda60f0fb42afa2 commit 8b3670491a67a5ab16a3df58bfda60f0fb42afa2 Author: brucedawson <brucedawson@chromium.org> Date: Tue Mar 15 01:24:39 2016 Update chrome_elf_unittests imports list for VS 2015 VS 2015 component builds import more DLLs so chrome_elf_unittests needs updating to reflect that. This change also tightens the restrictions on the import list - the CRT DLLs should only be needed in component builds. BUG= 440500 , 594360 Review URL: https://codereview.chromium.org/1801953003 Cr-Commit-Position: refs/heads/master@{#381145} [modify] https://crrev.com/8b3670491a67a5ab16a3df58bfda60f0fb42afa2/chrome_elf/elf_imports_unittest.cc
,
Mar 15 2016
Bots are green again. |
||
►
Sign in to add a comment |
||
Comment 1 by brucedaw...@chromium.org
, Mar 14 2016Status: Assigned (was: Untriaged)