New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594358 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Send the value of google_brand::GetBrand in component update checks

Project Member Reported by sorin@chromium.org, Mar 12 2016

Issue description

Component update checks are missing the value of the "brand" attribute as defined by https://github.com/google/omaha/blob/wiki/ServerProtocolV3.md.

 

Comment 1 by sorin@chromium.org, Mar 14 2016

Cc: saswat@chromium.org rpop@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1fafb7d1fe7ddd214c97f47bc74a97f0848b68d

commit a1fafb7d1fe7ddd214c97f47bc74a97f0848b68d
Author: sorin <sorin@chromium.org>
Date: Wed Mar 23 17:54:42 2016

Send the value of google_brand::GetBrand in component update checks.

BUG= 594358 

Review URL: https://codereview.chromium.org/1823273002

Cr-Commit-Position: refs/heads/master@{#382876}

[modify] https://crrev.com/a1fafb7d1fe7ddd214c97f47bc74a97f0848b68d/chrome/browser/component_updater/chrome_component_updater_configurator.cc
[modify] https://crrev.com/a1fafb7d1fe7ddd214c97f47bc74a97f0848b68d/chrome/browser/extensions/updater/chrome_update_client_config.cc
[modify] https://crrev.com/a1fafb7d1fe7ddd214c97f47bc74a97f0848b68d/chrome/browser/extensions/updater/chrome_update_client_config.h
[modify] https://crrev.com/a1fafb7d1fe7ddd214c97f47bc74a97f0848b68d/components/update_client/configurator.h
[modify] https://crrev.com/a1fafb7d1fe7ddd214c97f47bc74a97f0848b68d/components/update_client/test_configurator.cc
[modify] https://crrev.com/a1fafb7d1fe7ddd214c97f47bc74a97f0848b68d/components/update_client/test_configurator.h
[modify] https://crrev.com/a1fafb7d1fe7ddd214c97f47bc74a97f0848b68d/components/update_client/update_checker.cc
[modify] https://crrev.com/a1fafb7d1fe7ddd214c97f47bc74a97f0848b68d/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/a1fafb7d1fe7ddd214c97f47bc74a97f0848b68d/components/update_client/utils.cc
[modify] https://crrev.com/a1fafb7d1fe7ddd214c97f47bc74a97f0848b68d/components/update_client/utils.h
[modify] https://crrev.com/a1fafb7d1fe7ddd214c97f47bc74a97f0848b68d/components/update_client/utils_unittest.cc
[modify] https://crrev.com/a1fafb7d1fe7ddd214c97f47bc74a97f0848b68d/ios/chrome/browser/component_updater/ios_component_updater_configurator.cc

Comment 3 by sorin@chromium.org, Mar 31 2016

Status: Fixed (was: Started)

Sign in to add a comment