New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594329 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Improve autotest logging

Project Member Reported by ihf@chromium.org, Mar 12 2016

Issue description

Make gardening logs easier to read.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7aded908bc8b4ec3415733ca55b1ec2f74cd20b8

commit 7aded908bc8b4ec3415733ca55b1ec2f74cd20b8
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Sat Mar 12 07:20:31 2016

autotest: improve logging.

1) Move board spew to iteration.
2) Add iteration spew to system logs.

Also remove unused imports.

BUG= chromium:594329 
TEST=Ran locally, check messages
2016-03-11T23:18:13.609018-08:00 NOTICE logger[11099]: autotest runtest graphics_Sanity
2016-03-11T23:18:14.387432-08:00 NOTICE logger[11230]: autotest starting iteration /usr/local/autotest/results/default/graphics_Sanity/sysinfo/iteration.1 on lars_1.6GHz_2GB
2016-03-11T23:18:31.713627-08:00 NOTICE logger[11292]: autotest finished iteration /usr/local/autotest/results/default/graphics_Sanity/sysinfo/iteration.1

Change-Id: I53a42cc89a1393e86fb6e3037fe590f0390e5d9c
Reviewed-on: https://chromium-review.googlesource.com/332207
Commit-Ready: Ilja Friedel <ihf@chromium.org>
Tested-by: Ilja Friedel <ihf@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[modify] https://crrev.com/7aded908bc8b4ec3415733ca55b1ec2f74cd20b8/client/bin/base_sysinfo.py
[modify] https://crrev.com/7aded908bc8b4ec3415733ca55b1ec2f74cd20b8/client/bin/site_sysinfo.py
[modify] https://crrev.com/7aded908bc8b4ec3415733ca55b1ec2f74cd20b8/client/bin/test.py

Comment 2 by ihf@chromium.org, Mar 13 2016

Status: Verified (was: Started)
The test.DEBUG logs now contain a first line with the board name as a reminder
03/12 15:48:13.177 INFO |      base_sysinfo:0358| ChromeOS BOARD = butterfly_1.1GHz_4GB

and messages can now be searched for "autotest" showing which other tests ran before on the DUT:
2016-03-12T22:39:34.493477+00:00 NOTICE logger[13383]: autotest runtest security_ASLR
2016-03-12T22:39:34.802603+00:00 NOTICE logger[13405]: autotest starting iteration /usr/local/autotest/results/default/security_ASLR/sysinfo/iteration.1 on butterfly_1.1GHz_4GB
[...]
2016-03-12T22:39:40.763066+00:00 NOTICE logger[14443]: autotest finished iteration /usr/local/autotest/results/default/security_ASLR/sysinfo/iteration.1

Comment 3 by ihf@chromium.org, Mar 13 2016

Cc: keta...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d08a4d3e1227297ad73e7edca85f38cca7b2e30b

commit d08a4d3e1227297ad73e7edca85f38cca7b2e30b
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Sun Mar 13 05:06:19 2016

autotest: fix brillo and cleanup.

1) Brillo may not have logger installed. Fail silently.
2) Make pylint happier.

BUG= chromium:594329 
TEST=pylint/pyformat.

Change-Id: I14d1e19fc765bce78f8631b1bd42f1848bd2bcad
Reviewed-on: https://chromium-review.googlesource.com/332237
Commit-Ready: Dan Shi <dshi@google.com>
Tested-by: Ilja Friedel <ihf@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/d08a4d3e1227297ad73e7edca85f38cca7b2e30b/client/bin/base_sysinfo.py
[modify] https://crrev.com/d08a4d3e1227297ad73e7edca85f38cca7b2e30b/client/bin/test.py

Sign in to add a comment