Compile step failing across Windows builders |
||
Issue description
,
Mar 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e59014501844be38d71617a7d218a242cc76574 commit 6e59014501844be38d71617a7d218a242cc76574 Author: brucedawson <brucedawson@chromium.org> Date: Sat Mar 12 15:39:41 2016 Reland of Fix mini_installer to handle VS 2015 component builds (patchset #1 id:1 of https://codereview.chromium.org/1791483004/ ) Reason for revert: Suspect this was not the cause of Win32 builds breaking, and I don't want developers hitting this mini_installer bug. If reverting again please provide more details and a link to the breaks. Original issue's description: > Revert of Fix mini_installer to handle VS 2015 component builds (patchset #1 id:1 of https://codereview.chromium.org/1787883005/ ) > > Reason for revert: > Suspect this has caused Win32 builders to break. > > BUG= 594322 > > Original issue's description: > > Fix mini_installer to handle VS 2015 component builds > > > > The mini_installer needs to unpack more CRT DLLs now that we are using > > VS 2015. This change supports that, while still being VS 2013 > > compatible. > > > > TBR=gab@chromium.org > > BUG= 594294 > > > > Committed: https://crrev.com/9ec74cd783f5a5eff2d5750f3bd072d5a577e0e4 > > Cr-Commit-Position: refs/heads/master@{#380833} > > TBR=dpranke@chromium.org,stanisc@chromium.org,gab@chromium.org,brucedawson@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 594294 > > Committed: https://crrev.com/76311f1cf896615df4fa82b8421ae81cec9b7873 > Cr-Commit-Position: refs/heads/master@{#380838} TBR=dpranke@chromium.org,stanisc@chromium.org,gab@chromium.org,vmiura@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 594322 Review URL: https://codereview.chromium.org/1793753002 Cr-Commit-Position: refs/heads/master@{#380876} [modify] https://crrev.com/6e59014501844be38d71617a7d218a242cc76574/chrome/tools/build/win/create_installer_archive.py
,
Mar 14 2016
Links to breaks are in this issue. This was the only change that seemed related to the break at "https://build.chromium.org/p/chromium.gpu/builders/GPU%20Win%20Builder/builds/40009" Thanks for your understanding. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Mar 12 2016