New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 594318 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 238804



Sign in to add a comment

The test newTabPagesShareProcess in ProcessesApiTest.Processes Fails for --site-per-process

Project Member Reported by afakhry@chromium.org, Mar 12 2016

Issue description

https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/8360

This test expects that NTPs should always share the same process. This seems not to make any sense in --site-per-process.

I will disable it now, until we figure the importance of this test or a replacement.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93d2ab1c0f3667e844390c30779b8ecb1d15bfed

commit 93d2ab1c0f3667e844390c30779b8ecb1d15bfed
Author: afakhry <afakhry@chromium.org>
Date: Sun Mar 13 00:34:42 2016

Disable newTabPagesShareProcess in ProcessesApiTest.Processes

This test doesn't make sense in --site-per-process. Disable for now.

TBR=nick@chromium.org
BUG= 594318 
TEST=browser_tests --gtest_filter=ProcessesApiTest.Processes --site-per-process

Review URL: https://codereview.chromium.org/1792453004

Cr-Commit-Position: refs/heads/master@{#380887}

[modify] https://crrev.com/93d2ab1c0f3667e844390c30779b8ecb1d15bfed/chrome/test/data/extensions/api_test/processes/api/test.js

Comment 2 by creis@chromium.org, Mar 14 2016

Components: Internals>Sandbox>SiteIsolation
Thanks for getting the bot green again.

I would expect this test to work in --site-per-process, since that mode doesn't affect whether we consolidate instances of sites like the NTP into a single process.  Indeed, creating multiple NTPs when running with --site-per-process shows them all in the same process.

We'll have to take a closer look to see why the test isn't failing.
Components: Tests>Flaky
Labels: -Pri-2 Sheriff-Chromium Pri-1
This test is also flaky on Win7 Tests (dbg). Sample builds:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/47103
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/47085
Yeah, it's not clear to me that the failures are actually related to --site-per-process, fwiw.
Yeah, it seems from the builders in #3 that the test testOnUnresponsive() is flaky on Windows.

Comment 6 by grt@chromium.org, Mar 30 2016

Labels: -Sheriff-Chromium
Removing Sheriff-Chromium since this issue has an owner.
Blocking: 238804
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7051dd3f77013b0e0bcc7447cdbcfe38aeb66a20

commit 7051dd3f77013b0e0bcc7447cdbcfe38aeb66a20
Author: afakhry <afakhry@chromium.org>
Date: Tue Aug 02 21:31:16 2016

Fix newTabPageShareProces() in chrome.processes API browsertests

The test used to fail in --site-per-process

BUG= 594318 
TEST=browser_tests --gtest_filter=ProcessesApiTest.Processes --site-per-process

Review-Url: https://codereview.chromium.org/2205563002
Cr-Commit-Position: refs/heads/master@{#409329}

[modify] https://crrev.com/7051dd3f77013b0e0bcc7447cdbcfe38aeb66a20/chrome/test/data/extensions/api_test/processes/api/test.js

Status: Fixed (was: Started)

Sign in to add a comment